feat: New module azure-stack-hci/cluster module (rebased) #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mtb-azure-stack-hci-cluster
…into mtb-azure-stack-hci-cluster
Co-authored-by: Alexander Sehr <[email protected]>
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
17 tasks
AlexanderSehr
added a commit
that referenced
this pull request
Feb 12, 2025
## Description Adds new Azure Stack HCI Cluster AVM module. Some helper modules for e2e testing are placed here `avm\utilities\e2e-template-assets\templates\azure-stack-hci`, which will also be using them for other HCI resource modules (always needing to deploy an HCI cluster in Azure to test on). If this is not the right location for this sort of shared asset, please let us know. For some reason Set-AVMModule does not generate cross-ref correctly on my dev machine, it is manually added back to pass the static validation. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/workflows/avm.res.azure-stack-hci.cluster.yml) | ## Type of Change - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings As agreed offline, [the existing draft pull request](#4155) by @AlexanderSehr and [the previous pull request](#3364) by @mbrat2005 will be superseded by this. Special thanks to their contribution to this pull request. ## Maintainer checklist: * [ ] Microsoft.AzureStackHCI RP registered (in order to grant permissions before starting) * [ ] Service Principal created and granted Azure Resource Bridge Deployment role on the management group (deployment will create subscription-level permissions, but parallel deployments/failures may clean up the required role). Create a secret credential. * [ ] CI-arbDeploymentAppId * [ ] CI-arbDeploymentSPObjectId (from Enterprise Application) * [ ] CI-arbDeploymentServicePrincipalSecret * [ ] CI-hciResourceProviderObjectId (Get-AzADServicePrincipal -ApplicationId 1412d89f-b8a8-4111-b4fd-e82905cbd85d) --------- Co-authored-by: Matthew Bratschun <[email protected]> Co-authored-by: Matthew Bratschun <[email protected]> Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Hangyu Xu <[email protected]>
|
Closing in favor of #4417 |
anderseide
pushed a commit
to anderseide/avm-bicep-registry-modules
that referenced
this pull request
Feb 19, 2025
](https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/workflows/avm.res.azure-stack-hci.cluster.yml){kind=link}
## Description Adds new Azure Stack HCI Cluster AVM module. Some helper modules for e2e testing are placed here `avm\utilities\e2e-template-assets\templates\azure-stack-hci`, which will also be using them for other HCI resource modules (always needing to deploy an HCI cluster in Azure to test on). If this is not the right location for this sort of shared asset, please let us know. For some reason Set-AVMModule does not generate cross-ref correctly on my dev machine, it is manually added back to pass the static validation. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/workflows/avm.res.azure-stack-hci.cluster.yml) | ## Type of Change - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings As agreed offline, [the existing draft pull request](Azure#4155) by @AlexanderSehr and [the previous pull request](Azure#3364) by @mbrat2005 will be superseded by this. Special thanks to their contribution to this pull request. ## Maintainer checklist: * [ ] Microsoft.AzureStackHCI RP registered (in order to grant permissions before starting) * [ ] Service Principal created and granted Azure Resource Bridge Deployment role on the management group (deployment will create subscription-level permissions, but parallel deployments/failures may clean up the required role). Create a secret credential. * [ ] CI-arbDeploymentAppId * [ ] CI-arbDeploymentSPObjectId (from Enterprise Application) * [ ] CI-arbDeploymentServicePrincipalSecret * [ ] CI-hciResourceProviderObjectId (Get-AzADServicePrincipal -ApplicationId 1412d89f-b8a8-4111-b4fd-e82905cbd85d) --------- Co-authored-by: Matthew Bratschun <[email protected]> Co-authored-by: Matthew Bratschun <[email protected]> Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Hangyu Xu <[email protected]>
anderseide
pushed a commit
to anderseide/avm-bicep-registry-modules
that referenced
this pull request
Feb 23, 2025
## Description Adds new Azure Stack HCI Cluster AVM module. Some helper modules for e2e testing are placed here `avm\utilities\e2e-template-assets\templates\azure-stack-hci`, which will also be using them for other HCI resource modules (always needing to deploy an HCI cluster in Azure to test on). If this is not the right location for this sort of shared asset, please let us know. For some reason Set-AVMModule does not generate cross-ref correctly on my dev machine, it is manually added back to pass the static validation. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Infrastructure-as-code-Automation/bicep-registry-modules/actions/workflows/avm.res.azure-stack-hci.cluster.yml) | ## Type of Change - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings As agreed offline, [the existing draft pull request](Azure#4155) by @AlexanderSehr and [the previous pull request](Azure#3364) by @mbrat2005 will be superseded by this. Special thanks to their contribution to this pull request. ## Maintainer checklist: * [ ] Microsoft.AzureStackHCI RP registered (in order to grant permissions before starting) * [ ] Service Principal created and granted Azure Resource Bridge Deployment role on the management group (deployment will create subscription-level permissions, but parallel deployments/failures may clean up the required role). Create a secret credential. * [ ] CI-arbDeploymentAppId * [ ] CI-arbDeploymentSPObjectId (from Enterprise Application) * [ ] CI-arbDeploymentServicePrincipalSecret * [ ] CI-hciResourceProviderObjectId (Get-AzADServicePrincipal -ApplicationId 1412d89f-b8a8-4111-b4fd-e82905cbd85d) --------- Co-authored-by: Matthew Bratschun <[email protected]> Co-authored-by: Matthew Bratschun <[email protected]> Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Hangyu Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebase of #3364
Original description
Pipeline Reference
Type of Change
version.json:version.json.version.json.