Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste as BicepParams #15897

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Conversation

miqm
Copy link
Collaborator

@miqm miqm commented Dec 16, 2024

Fixes #15769

Changes

  • Pasting json values in bicepparam is converted to bicep native object
  • Pasting entire json parameters file is being decompiled into param statements
    • if using directive is already there - it's not being added for the second time
    • overlapping param will be duplicated though

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.37%. Comparing base (108d816) to head (43e1263).
Report is 1801 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (108d816) and HEAD (43e1263). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (108d816) HEAD (43e1263)
dotnet 4 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #15897       +/-   ##
===========================================
- Coverage   94.28%    9.37%   -84.91%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      288   -100503     
  Branches     8734      123     -8611     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      260     -4335     
+ Partials     1168        1     -1167     
Flag Coverage Δ
dotnet ?
typescript 9.37% <ø> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1104 files with indirect coverage changes

@StephenWeatherford
Copy link
Contributor

@miqm Been OOF, I can take a look tomorrow.

@StephenWeatherford
Copy link
Contributor

I've left some commets, not done yet.

@miqm
Copy link
Collaborator Author

miqm commented Dec 30, 2024

@StephenWeatherford I've fixed highlighted problems

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Add languageId to telemetry and I'll be ready to approve. Thanks!

@miqm
Copy link
Collaborator Author

miqm commented Jan 14, 2025

@StephenWeatherford please merge as I don't have permissions to do so.

@StephenWeatherford StephenWeatherford merged commit e659e99 into Azure:main Jan 15, 2025
40 checks passed
@StephenWeatherford
Copy link
Contributor

@mimq Sorry, done!

Copy link
Contributor

Test this change out locally with the following install scripts (Action run 12780302752)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 12780302752
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 12780302752"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 12780302752
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 12780302752"

@miqm miqm deleted the feat/paste-as-bicepparam branch January 15, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste as bicep in bicepparam files doesn't work
3 participants