-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste as BicepParams #15897
Paste as BicepParams #15897
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15897 +/- ##
===========================================
- Coverage 94.28% 9.37% -84.91%
===========================================
Files 1113 7 -1106
Lines 100791 288 -100503
Branches 8734 123 -8611
===========================================
- Hits 95028 27 -95001
+ Misses 4595 260 -4335
+ Partials 1168 1 -1167
Flags with carried forward coverage won't be shown. Click here to find out more. |
@miqm Been OOF, I can take a look tomorrow. |
src/Bicep.LangServer/Handlers/BicepDecompileForPasteCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/Bicep.LangServer.UnitTests/Handlers/BicepDecompileForPasteCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
I've left some commets, not done yet. |
@StephenWeatherford I've fixed highlighted problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Add languageId to telemetry and I'll be ready to approve. Thanks!
@StephenWeatherford please merge as I don't have permissions to do so. |
@mimq Sorry, done! |
Test this change out locally with the following install scripts (Action run 12780302752) VSCode
Azure CLI
|
Fixes #15769
Changes
param
statementsusing
directive is already there - it's not being added for the second timeparam
will be duplicated thoughContributing a feature