Various improvements to testing #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
improve_ci_times
branch
30 times, most recently
from
4754f3b to
1a0e72b
Compare
cpuguy83
force-pushed
the
improve_ci_times
branch
7 times, most recently
from
18661ea to
f62af9d
Compare
cpuguy83
force-pushed
the
improve_ci_times
branch
2 times, most recently
from
9ad6394 to
c2f33b8
Compare
Signed-off-by: Brian Goff <[email protected]>
Before this was calling `t.Log` for every read from the log file. What we really want is to to call `t.Log` for every line since a `Read` may return a partial line which will look weird in the output and be difficult to read. This also changes things to always write the build logs to the test log instead of just on failure so its easier to see what's happening even on a successful test run. Signed-off-by: Brian Goff <[email protected]>
This makes sure we use the same cache keys for both the main Dockerfile and the test fixtures so that we can avoid needing to pull down a bunch of dependencies that we've already pulled down before. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
improve_ci_times
branch
from
c2f33b8 to
7821922
Compare
|
The test failure is actually on main... I'm bisecting this now. |
|
Pushed commit to fix. |
cpuguy83
force-pushed
the
improve_ci_times
branch
from
727136e to
64f0a54
Compare
adamperlin
reviewed
Jan 8, 2025
adamperlin
requested changes
Jan 8, 2025
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
This doesn't end up saving us any time and potentially slows down a test run even so we can just remove it.
This was ignoring all non-test events, unfortunately this means if there is a panic or a test timeout we may not detect the failure. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
These should not be processed since any variable substitution should be handled by env. Also to note: This use of arg expansion was causing tests to fail, though we didn't see it due to some issues with CI infra. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
improve_ci_times
branch
from
64f0a54 to
1532c70
Compare
adamperlin
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t.Parallal()andstartTestSpancallsSupersedes #482
Fixes #476