-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "And", "Or", and Relationships as valid OrderByInput types. #2625
Merged
+69
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
…/data-api-builder into dev/aaronburtle/OrderByAndOrBugFix
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Mar 24, 2025
Aniruddh25
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RubenCerna2079
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2286
What is this change?
The
InputTypeBuilder
class holds a function calledGenerateOrderByInputTypeForObjectType
, which is responsible for populating the GraphQL Schema with the valid OrderByInput types. It was mistakenly adding in "and", "or", and columns that are in entities associated through relationships as valid OrderByInput types. "and" and "or" will never be valid input types, and we do not yet support order by using columns from related entities.How was this tested?
Manually verified that the correct error was returned when trying to use the incorrect orderBy queries, and manually verified that we no longer have them in the schema.
Added regression test to verify we get an error when attempting these queries.
Sample Request(s)
These are some example graph QL queries that are invalid but were showing as valid in our schema without this fix.