docs: add the takeover how-to doc (preview)#967
Merged
ryanzhang-oss merged 5 commits intoAzure:mainfrom Mar 18, 2025
Merged
Conversation
ryanzhang-oss
previously approved these changes
Nov 23, 2024
jwtty
reviewed
Dec 12, 2024
Comment on lines
+41
to
+56
|
|
||
| ```sh | ||
| kubectl config use-context member-2-admin | ||
| kubectl create ns work-2 | ||
| kubectl label ns work-2 app=work-2 | ||
| kubectl label ns work-2 owner=wesker | ||
| ``` | ||
|
|
||
| * Switch to the hub cluster, and create the same namespace, but with a slightly different set of labels: | ||
|
|
||
| ```sh | ||
| kubectl config use-context hub-admin | ||
| kubectl create ns work-2 | ||
| kubectl label ns work-2 app=work-2 | ||
| kubectl label ns work-2 owner=redfield | ||
| ``` |
Contributor
There was a problem hiding this comment.
better to use a configMap to illustrate both the label and field
Contributor
There was a problem hiding this comment.
or even better, use a CRD which directly addresses infoSys's issue.
ryanzhang-oss
approved these changes
Mar 18, 2025
Contributor
ryanzhang-oss
left a comment
There was a problem hiding this comment.
please address the comments in the follow up PR
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a how-to doc for the new takeover experience.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
N/A
Special notes for your reviewer