feat: add server-side option based on force option

README.md

@@ -113,6 +113,10 @@ Following are the key capabilities of this action:
     <td>force </br></br>(Optional)</td>
     <td>Deploy when a previous deployment already exists. If true then '--force' argument is added to the apply command. Using '--force' argument is not recommended in production.</td>
   </tr>
+  <tr>
+    <td>server-side </br></br>(Optional)</td>
+    <td>The apply command runs in the server instead of the client. If true then '--server-side' argument is added to the apply command.</td>
+  </tr>
   <tr>
     <td>annotate-resources</br></br>(Optional)</td>
     <td>Acceptable values: true/false</br>Default value: true</br>Switch whether to annotate the resources or not. If set to false all annotations are skipped completely.</td>

action.yml

@@ -55,6 +55,10 @@ inputs:
       description: 'Deploy when a previous deployment already exists. If true then --force argument is added to the apply command'
       required: false
       default: false
+   server-side:
+      description: 'The apply command runs in the server instead of the client. If true then --server-side argument is added to the apply command.'
+      required: false
+      default: false
    token:
       description: 'Github token'
       default: ${{ github.token }}

src/strategyHelpers/canary/podCanaryHelper.ts

@@ -71,8 +71,9 @@ export async function deployPodCanary(
    core.debug('New objects list: ' + JSON.stringify(newObjectsList))
    const manifestFiles = fileHelper.writeObjectsToFile(newObjectsList)
    const forceDeployment = core.getInput('force').toLowerCase() === 'true'
+   const serverSideDeployment = core.getInput('server-side').toLowerCase() === 'true'
 
-   const execResult = await kubectl.apply(manifestFiles, forceDeployment)
+   const execResult = await kubectl.apply(manifestFiles, forceDeployment, serverSideDeployment)
    return {execResult, manifestFiles}
 }
 

src/strategyHelpers/canary/smiCanaryHelper.ts

@@ -97,7 +97,8 @@ export async function deploySMICanary(
    )
    const newFilePaths = fileHelper.writeObjectsToFile(newObjectsList)
    const forceDeployment = core.getInput('force').toLowerCase() === 'true'
-   const result = await kubectl.apply(newFilePaths, forceDeployment)
+   const serverSideDeployment = core.getInput('server-side').toLowerCase() === 'true'
+   const result = await kubectl.apply(newFilePaths, forceDeployment, serverSideDeployment)
    const svcDeploymentFiles = await createCanaryService(kubectl, filePaths)
    newFilePaths.push(...svcDeploymentFiles)
    return {execResult: result, manifestFiles: newFilePaths}
@@ -192,8 +193,9 @@ async function createCanaryService(
    const manifestFiles = fileHelper.writeObjectsToFile(newObjectsList)
    manifestFiles.push(...trafficObjectsList)
    const forceDeployment = core.getInput('force').toLowerCase() === 'true'
+   const serverSideDeployment = core.getInput('server-side').toLowerCase() === 'true'
 
-   const result = await kubectl.apply(manifestFiles, forceDeployment)
+   const result = await kubectl.apply(manifestFiles, forceDeployment, server-side)
    checkForErrors([result])
    return manifestFiles
 }
@@ -249,7 +251,8 @@ async function adjustTraffic(
    }
 
    const forceDeployment = core.getInput('force').toLowerCase() === 'true'
-   const result = await kubectl.apply(trafficSplitManifests, forceDeployment)
+   const serverSideDeployment = core.getInput('server-side').toLowerCase() === 'true'
+   const result = await kubectl.apply(trafficSplitManifests, forceDeployment, serverSideDeployment)
    checkForErrors([result])
    return trafficSplitManifests
 }

src/strategyHelpers/deploymentHelper.ts

@@ -89,16 +89,18 @@ export async function deployManifests(
          )
 
          const forceDeployment = core.getInput('force').toLowerCase() === 'true'
+         const serverSideDeployment = core.getInput('server-side').toLowerCase() === 'true'
          if (trafficSplitMethod === TrafficSplitMethod.SMI) {
             const updatedManifests = appendStableVersionLabelToResource(files)
 
             const result = await kubectl.apply(
                updatedManifests,
-               forceDeployment
+               forceDeployment,
+	            serverSideDeployment
             )
             checkForErrors([result])
          } else {
-            const result = await kubectl.apply(files, forceDeployment)
+            const result = await kubectl.apply(files, forceDeployment, serverSideDeployment)
             checkForErrors([result])
          }
 

src/types/kubectl.test.ts

@@ -90,7 +90,7 @@ describe('Kubectl class', () => {
 
       it('applies a configuration with force when specified', async () => {
          const configPaths = ['configPath1', 'configPath2', 'configPath3']
-         const result = await kubectl.apply(configPaths, true)
+         const result = await kubectl.apply(configPaths, true, false)
          expect(result).toBe(execReturn)
          expect(exec.getExecOutput).toBeCalledWith(
             kubectlPath,
@@ -106,6 +106,24 @@ describe('Kubectl class', () => {
          )
       })
 
+      it('applies a configuration with server-side when specified', async () => {
+         const configPaths = ['configPath1', 'configPath2', 'configPath3']
+         const result = await kubectl.apply(configPaths, false, true)
+         expect(result).toBe(execReturn)
+         expect(exec.getExecOutput).toBeCalledWith(
+            kubectlPath,
+            [
+               'apply',
+               '-f',
+               configPaths[0] + ',' + configPaths[1] + ',' + configPaths[2],
+               '--server-side',
+               '--namespace',
+               testNamespace
+            ],
+            {silent: false}
+         )
+      })
+
       it('describes a resource', async () => {
          const resourceType = 'type'
          const resourceName = 'name'

src/types/kubectl.ts

@@ -34,7 +34,8 @@ export class Kubectl {
 
    public async apply(
       configurationPaths: string | string[],
-      force: boolean = false
+      force: boolean = false,
+      serverSide: boolean = false,
    ): Promise<ExecOutput> {
       try {
          if (!configurationPaths || configurationPaths?.length === 0)
@@ -46,6 +47,7 @@ export class Kubectl {
             createInlineArray(configurationPaths)
          ]
          if (force) applyArgs.push('--force')
+	      if (serverSide) applyArgs.push('--server-side')
 
          return await this.execute(applyArgs.concat(this.getFlags()))
       } catch (err) {