-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ListNodeImageVersions + shared image gallery support #526
feat: ListNodeImageVersions + shared image gallery support #526
Conversation
Pull Request Test Coverage Report for Build 12442803767Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pease resolve merge conflicts (which should include removal of AKSNodeClass imageVersion)
…ng out unsupported galleries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 19 changed files in this pull request and generated 1 suggestion.
Files not reviewed (14)
- Makefile-az.mk: Language not supported
- pkg/providers/imagefamily/image_test.go: Evaluated as low risk
- pkg/cloudprovider/drift.go: Evaluated as low risk
- pkg/test/options.go: Evaluated as low risk
- pkg/fake/nodeimageversionsapi.go: Evaluated as low risk
- pkg/providers/instancetype/suite_test.go: Evaluated as low risk
- pkg/providers/instance/instance.go: Evaluated as low risk
- pkg/providers/instance/azure_client.go: Evaluated as low risk
- pkg/test/environment.go: Evaluated as low risk
- karpenter-values-template.yaml: Evaluated as low risk
- pkg/providers/imagefamily/azlinux.go: Evaluated as low risk
- pkg/operator/operator.go: Evaluated as low risk
- pkg/providers/imagefamily/ubuntu_2204.go: Evaluated as low risk
- pkg/providers/imagefamily/types.go: Evaluated as low risk
Comments skipped due to low confidence (1)
pkg/providers/imagefamily/image.go:132
- Ensure that the new string splitting approach correctly handles all possible cases by adding test cases.
imageID, ok := p.imageCache.Get(key)
…provider for later
…gallery id retrivial functions
… implementation doesn't use it
…to shared image gallery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and ready to go (caching may be further simplified, I think, but that's minor), but E2E tests are failing:
https://github.com/Azure/karpenter-provider-azure/actions/runs/12309122786/job/34355672677
Error: variable ${SIG_SUBSCRIPTION_ID} not set
…Azure/karpenter-provider-azure into bsoghigian/list-node-image-versions-poc
@Bryce-Soghigian please link to evidence of E2E tests passing |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 E2E: https://github.com/Azure/karpenter-provider-azure/actions/runs/12439573149
(Please follow up with including NVMe-only VM SKUs when Shared Image Gallery is used.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow up with #617 (comment) (could be separate PR)
Fixes #
Description
This pr introduces
Open Qs:
Are we ok with all Nodes with Community Image gallery node images being drifted over to use SIG in managed karpenter with this change?
Should we implement the windows side changes too for the NodeImageVersions api?
How was this change tested?
Does this change impact docs?
Release Note