Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESRI Enterprise Add-On: SFI & ZTA updates #1136

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
dc03229
Integrated tier3
jamasten Sep 27, 2024
0ecddfc
Removed unnecessary file
jamasten Sep 27, 2024
8083cab
Fixed formatting, Removed default value
jamasten Sep 27, 2024
a2e2a54
Added script
jamasten Sep 27, 2024
f42efcf
Added parameter
jamasten Sep 27, 2024
7808ce5
Updated image terms script, Removed unnecessary dependency
jamasten Sep 27, 2024
32eb755
Updated tags to use safe dereference
jamasten Sep 27, 2024
72df11d
Created script file for certificate creation
jamasten Sep 30, 2024
e47374f
Created script file for ESRI licenses
jamasten Sep 30, 2024
a5bf01c
Updated URLs
jamasten Sep 30, 2024
824b3d3
Removed run command for module installation
jamasten Oct 4, 2024
77d35b5
Merge branch 'main' into 1068-esri-enterprise-updates
jamasten Oct 15, 2024
f9ab450
Merge branch 'main' into 1068-esri-enterprise-updates
jamasten Oct 17, 2024
bf6c216
Removed bicep config file
jamasten Oct 17, 2024
6d71c88
Removed unnecessary file
jamasten Oct 17, 2024
b7e7b37
Merge branch 'main' into 1068-esri-enterprise-updates
jamasten Nov 28, 2024
f25abc0
Fixed linter issue
jamasten Nov 28, 2024
2d35821
Fixed linter issue
jamasten Nov 28, 2024
179cb8e
Removed unnecessary dependencies
jamasten Dec 12, 2024
25478b8
Fixed deployment scope
jamasten Dec 12, 2024
d2443a4
Compiled bicep changes
jamasten Dec 12, 2024
8d3c1aa
GitHub Action: Build Bicep to JSON
invalid-email-address Dec 12, 2024
b48884b
Compiled bicep changes
jamasten Dec 12, 2024
bb9f12b
Compiled bicep changes
jamasten Dec 12, 2024
b446d27
Fixed API versions for AVD
jamasten Dec 13, 2024
e052074
Fixed scope on VNET links
jamasten Dec 18, 2024
a10a54e
Updated default values for params
jamasten Dec 20, 2024
c8b9781
Removed unnecessary params, Updated param values
jamasten Dec 20, 2024
eebcdcc
Added filter for image SKUs, Optimized default value for image SKU
jamasten Dec 21, 2024
9fba127
Created step for control plane
jamasten Dec 21, 2024
77bd644
Added info box to show selected groups
jamasten Dec 21, 2024
798d989
Added warning info boxes for VM quota
jamasten Dec 22, 2024
566fe51
Added replace to remove double spaces
jamasten Dec 23, 2024
a81f7f9
Fixed tags
jamasten Dec 26, 2024
24288e6
Added file
jamasten Dec 26, 2024
060ed46
Fixed dependencies & params
jamasten Dec 26, 2024
7a06470
Organized resources by deployment order
jamasten Dec 26, 2024
9577e8a
Simplified the scopes
jamasten Jan 16, 2025
3ad3311
Updated file path for consistency
jamasten Jan 16, 2025
d51cae7
Added script to set DNS client
jamasten Jan 16, 2025
f7c92de
Updated param names, Moved inline script to file
jamasten Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ $AzureManagementHeader = @{
$SessionHosts = (Invoke-RestMethod `
-Headers $AzureManagementHeader `
-Method 'GET' `
-Uri $($ResourceManagerUriFixed + 'subscriptions/' + $SubscriptionId + '/resourceGroups/' + $HostPoolResourceGroupName + '/providers/Microsoft.DesktopVirtualization/hostPools/' + $HostPoolName + '/sessionHosts?api-version=2022-02-10-preview')).value.name
-Uri $($ResourceManagerUriFixed + 'subscriptions/' + $SubscriptionId + '/resourceGroups/' + $HostPoolResourceGroupName + '/providers/Microsoft.DesktopVirtualization/hostPools/' + $HostPoolName + '/sessionHosts?api-version=2023-09-05')).value.name

# Enable drain mode for the AVD session hosts
for($i = $SessionHostIndex; $i -lt $($SessionHostIndex + $SessionHostCount); $i++)
Expand All @@ -43,5 +43,5 @@ for($i = $SessionHostIndex; $i -lt $($SessionHostIndex + $SessionHostCount); $i+
-Body (@{properties = @{allowNewSession = $false}} | ConvertTo-Json) `
-Headers $AzureManagementHeader `
-Method 'PATCH' `
-Uri $($ResourceManagerUriFixed + 'subscriptions/' + $SubscriptionId + '/resourceGroups/' + $HostPoolResourceGroupName + '/providers/Microsoft.DesktopVirtualization/hostPools/' + $HostPoolName + '/sessionHosts/' + $SessionHostName + '?api-version=2022-02-10-preview') | Out-Null
-Uri $($ResourceManagerUriFixed + 'subscriptions/' + $SubscriptionId + '/resourceGroups/' + $HostPoolResourceGroupName + '/providers/Microsoft.DesktopVirtualization/hostPools/' + $HostPoolName + '/sessionHosts/' + $SessionHostName + '?api-version=2023-09-05') | Out-Null
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ Invoke-RestMethod `
-Body (@{properties = @{friendlyName = $FriendlyName.Replace('"', '')}} | ConvertTo-Json) `
-Headers $AzureManagementHeader `
-Method 'PATCH' `
-Uri $($ResourceManagerUriFixed + 'subscriptions/' + $SubscriptionId + '/resourceGroups/' + $ResourceGroupName + '/providers/Microsoft.DesktopVirtualization/applicationGroups/' + $ApplicationGroupName + '/desktops/SessionDesktop?api-version=2022-02-10-preview') | Out-Null
-Uri $($ResourceManagerUriFixed + 'subscriptions/' + $SubscriptionId + '/resourceGroups/' + $ResourceGroupName + '/providers/Microsoft.DesktopVirtualization/applicationGroups/' + $ApplicationGroupName + '/desktops/SessionDesktop?api-version=2023-09-05') | Out-Null
8 changes: 4 additions & 4 deletions src/bicep/add-ons/azure-virtual-desktop/solution.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ param activeDirectorySolution string
param availability string = 'AvailabilityZones'

@description('The availability zones allowed for the AVD session hosts deployment location.')
param availabilityZones array
param availabilityZones array = ['1', '2', '3']

@description('The file name for the ZIP file containing the AVD agents and DSC configuration.')
param avdConfigurationZipFileName string = 'Configuration_1.0.02790.438.zip'
Expand Down Expand Up @@ -72,7 +72,7 @@ param domainName string = ''
param drainMode bool = false

@description('The email address to use for Defender for Cloud notifications.')
param emailSecurityContact string
param emailSecurityContact string = ''

@description('Determine whether to enable accelerated networking on the AVD session hosts. https://learn.microsoft.com/en-us/azure/virtual-network/accelerated-networking-overview')
param enableAcceleratedNetworking bool
Expand Down Expand Up @@ -132,7 +132,7 @@ param functionAppSubnetAddressPrefix string = ''
'EnabledForSessionHostsOnly'
])
@description('The type of public network access for the host pool.')
param hostPoolPublicNetworkAccess string
param hostPoolPublicNetworkAccess string = 'Enabled'

@allowed([
'Pooled'
Expand Down Expand Up @@ -302,7 +302,7 @@ param workspaceFriendlyName string = ''
'Enabled'
])
@description('The public network access setting on the AVD workspace either disables public network access or allows both public and private network access.')
param workspacePublicNetworkAccess string
param workspacePublicNetworkAccess string = 'Enabled'

// BATCH SESSION HOSTS
// The following variables are used to determine the batches to deploy any number of AVD session hosts.
Expand Down
Loading