Skip to content

Conversation

@lcarli
Copy link
Contributor

@lcarli lcarli commented Apr 29, 2025

Description

Fix ALZ workbook generator and and more ARG queries for Identity and Access Management on questions B03.03. B03.09, B03.11, B04.01 and B04.04

Related Issue

Link to any related issues or discussions here. This helps reviewers understand the context and the need for your changes.

Checklist

  • I've tested my changes to ensure they are ready for review.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the documentation (if applicable).
  • Resource Graph queries have been included (and tested) for recommendations where ever possible1.
  • Resource Graph queries have NOT been included (please explain below).

Additional Information

Is there any additional context, screenshots, or considerations that might help in the review process? Please include them here.

Reviewer Notes

Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡

Footnotes

  1. Details on how to add Azure Resource Graph queries to recommendations can be found here.

@lcarli lcarli requested review from a team, erjosito, fskelly, mbilalamjad and sdolgin as code owners April 29, 2025 03:25
@igorjnzl
Copy link
Contributor

igorjnzl commented May 7, 2025

Thanks @lcarli , we'll review this functionality of the workbook

Copy link
Contributor

@igorjnzl igorjnzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with team. Changes to workbook_create.py allow for handling of ARG with no compliant output.

@igorjnzl
Copy link
Contributor

@sdolgin @fskelly @erjosito @mbilalamjad any chance we can get this reviewed please?

@lcarli
Copy link
Contributor Author

lcarli commented Jun 12, 2025

I've also tested the code and everything is ok

@sdolgin sdolgin merged commit 633e5ad into Azure:main Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants