Skip to content

Conversation

@sdolgin
Copy link
Collaborator

@sdolgin sdolgin commented May 7, 2025

Description

This PR updates the custom Excel workbook used for importing JSON-based Graph check results. It includes a VBA fix that gracefully handles cases where the compliant property in the JSON file is "undefined" or missing altogether. Previously, this resulted in a confusing modal error message and halted the import process.

Related Issue

Fix for Issue #977

Checklist

  • I've tested my changes to ensure they are ready for review.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the documentation (if applicable).
  • Resource Graph queries have been included (and tested) for recommendations where ever possible1.
  • Resource Graph queries have NOT been included (please explain below).

Additional Information

  • Enhanced VBA logic in import_graph_results to normalize and validate the compliant field ("true", "false", "undefined", or empty).
  • Updated message box alerts and output formatting to ensure better user feedback and prevent ambiguous errors.

Reviewer Notes

@mbilalamjad approval upon validation testing

Footnotes

  1. Details on how to add Azure Resource Graph queries to recommendations can be found here.

@mbilalamjad
Copy link
Contributor

@igorjnzl, @erjosito your review is required

@igorjnzl igorjnzl merged commit def93e5 into Azure:main Oct 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants