Refactor ansible2 #662
Open
Refactor ansible2 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmicrosoft
requested review from
KimForss
and removed request for
a team and
KimForss
…rsing with python
hdamecharla
force-pushed
the
refactor_ansible2
branch
from
85671c6 to
ab906ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This pull request introduces a new module for setting variables in the SAP Mounts Role and Oracle Role, and integrates these modules into the existing Ansible tasks. The changes aim to streamline and centralize the handling of SAP mount parameters.New Modules for Setting Variables:
deploy/ansible/roles-sap-os/2.6-sap-mounts/library/setting_vars.py: Added a new module to set parameters for SAP mounts usingAnsibleModule.deploy/ansible/roles-sap-os/2.6-sap-mounts/library/setting_vars_oracle.py: Added a new module to set parameters for SAP mounts on Oracle usingAnsibleModule.Integration of New Modules:
deploy/ansible/roles-sap-os/2.6-sap-mounts/tasks/2.6.0-afs-mounts.yaml: Replaced multipleansible.builtin.set_facttasks with calls to the newsetting_varsmodule and updated references to use the output from this module. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]deploy/ansible/roles-sap-os/2.6-sap-mounts/tasks/2.6.1-anf-mounts.yaml: Replaced multipleansible.builtin.set_facttasks with calls to the newsetting_varsmodule and updated references to use the output from this module. [1] [2] [3]ng to resolve>Solution
This pull request introduces significant changes to the SAP mounts role in the Ansible deployment scripts. The main updates include the creation of new Python modules to handle variable settings, replacing inline Ansible tasks with calls to these modules, and updating the tasks to use the output from these modules. These changes aim to streamline the process and improve maintainability.New Python modules for setting variables:
deploy/ansible/roles-sap-os/2.6-sap-mounts/library/setting_vars.py: Created to set parameters for SAP mounts, including input and output parameters.deploy/ansible/roles-sap-os/2.6-sap-mounts/library/setting_vars_oracle.py: Created to set parameters for SAP mounts on Oracle.Updates to Ansible tasks:
deploy/ansible/roles-sap-os/2.6-sap-mounts/tasks/2.6.0-afs-mounts.yaml: Replaced inline variable setting tasks with calls to the newsetting_varsPython module and updated tasks to use the module's output. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]deploy/ansible/roles-sap-os/2.6-sap-mounts/tasks/2.6.1-anf-mounts.yaml: Similar updates to replace inline tasks with calls to the new module and use its output. [1] [2] [3]Tests
[Please provide steps to test the PR]
Private ADO links shared internally.
Notes