Add use_custom_dns_a_registration condition to key vault DNS A rec cr… #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZsoltParoczi
requested review from
dhruvmicrosoft
and removed request for
a team
|
@ZsoltParoczi , thank you for raising the PR. Please note that I have changed the base branch from #667 will be approved after review. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eation
Problem
Deployer key vault with private endpoint has issues with DNS A record creation. The private endpoint DNS zone group and the custom DNS A rec creation conflicts.
Solution
Add condition use_custom_dns_a_registration true for the DNS A record creation
Tests
Notes