fix: waitOn and fetch IPv4&v6 instead of localhost #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjk7989
requested review from
manekinekko,
sgollapudi77,
sulabh-msft and
Reshmi-Sriram
as code owners
sinedied
requested changes
May 31, 2023
sinedied
approved these changes
Jun 5, 2023
| }); | ||
|
|
||
| try { | ||
| const avaliableUrl = await Promise.any(promises); |
There was a problem hiding this comment.
Suggested change
| const avaliableUrl = await Promise.any(promises); | |
| const availableUrl = await Promise.any(promises); |
Small typo
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: issue #663.
Use 127.0.0.1 and [::1] for waitOn() and fetch() when using "swa start src --api-location api" with the default --host=localhost. Then check if any of them successes. This is because localhost may not be resolved to ipv4 on some systems.