Skip to content

Commit

Permalink
remove precondition which prevent using windows pool with overlay sin…
Browse files Browse the repository at this point in the history
…ce the feature is now GA
  • Loading branch information
lonegunmanb committed Feb 23, 2024
1 parent a935c12 commit b7faaf6
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions extra_node_pool.tf
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ resource "azurerm_kubernetes_cluster_node_pool" "node_pool_create_before_destroy
condition = can(regex("[a-z0-9]{1,8}", each.value.name))
error_message = "A Node Pools name must consist of alphanumeric characters and have a maximum lenght of 8 characters (4 random chars added)"
}
precondition {
condition = var.network_plugin_mode != "overlay" || each.value.os_type != "Windows"
error_message = "Windows Server 2019 node pools are not supported for Overlay and Windows support is still in preview"
}
precondition {
condition = var.network_plugin_mode != "overlay" || !can(regex("^Standard_DC[0-9]+s?_v2$", each.value.vm_size))
error_message = "With with Azure CNI Overlay you can't use DCsv2-series virtual machines in node pools. "
Expand Down Expand Up @@ -304,10 +300,6 @@ resource "azurerm_kubernetes_cluster_node_pool" "node_pool_create_after_destroy"
condition = can(regex("[a-z0-9]{1,8}", each.value.name))
error_message = "A Node Pools name must consist of alphanumeric characters and have a maximum lenght of 8 characters (4 random chars added)"
}
precondition {
condition = var.network_plugin_mode != "overlay" || each.value.os_type != "Windows"
error_message = "Windows Server 2019 node pools are not supported for Overlay and Windows support is still in preview"
}
precondition {
condition = var.network_plugin_mode != "overlay" || !can(regex("^Standard_DC[0-9]+s?_v2$", each.value.vm_size))
error_message = "With with Azure CNI Overlay you can't use DCsv2-series virtual machines in node pools. "
Expand Down

0 comments on commit b7faaf6

Please sign in to comment.