Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move breaking change details into separate docs. add notice on v7.0.0 #355

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 🚢

NoticeOnUpgradeTov7.0.md Outdated Show resolved Hide resolved
NoticeOnUpgradeTov7.0.md Outdated Show resolved Hide resolved
NoticeOnUpgradeTov7.0.md Outdated Show resolved Hide resolved
NoticeOnUpgradeTov7.0.md Outdated Show resolved Hide resolved
NoticeOnUpgradeTov7.0.md Outdated Show resolved Hide resolved
@lonegunmanb
Copy link
Member Author

Thanks @zioproto for the review, would you please give it another review? Thanks!

@zioproto
Copy link
Collaborator

LGTM, you might want to fix the "detials" typo the PR title before merging.

@lonegunmanb lonegunmanb changed the title Move breaking change detials into separate docs. add notice on v7.0.0 Move breaking change details into separate docs. add notice on v7.0.0 Apr 26, 2023
@lonegunmanb lonegunmanb merged commit ca7a93d into Azure:main Apr 26, 2023
1 check failed
skolobov pushed a commit to skolobov/terraform-azurerm-aks that referenced this pull request Oct 29, 2023
…Azure#355)

* move breaking change detials into separate docs. add notice on v7.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants