-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http_proxy_config): Add http_proxy_config #435
Conversation
The feature is GA: |
@isantospardo please run https://github.com/Azure/terraform-azurerm-aks#pre-commit--pr-check--test |
89c901e
to
385b210
Compare
Done, thanks for the quick note :) |
@microsoft-github-policy-service agree |
@jiaweitao001 could you have a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isantospardo for opening this pr, some review comments, and I'm afraid that we might need to defer this pr to our next major version, but I think it could be merged and released in one or two months.
Thanks a lot for the comments, I just updated the PR, and thanks for the time estimation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isantospardo for the update, only one comment.
Btw, I've merged a pr to update the readme file, so your pr contains a conflict with readme file now, would you please update your pr by rebase from the latest main branch and try again? Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isantospardo for your update, we have a conflict on the readme file, would you please rebase your branch with the latest main branch and try again? Thanks!
Related to: Azure#434 Signed-off-by: Iago Santos Pardo <[email protected]>
Signed-off-by: Iago Santos Pardo <[email protected]>
Signed-off-by: Iago Santos Pardo <[email protected]>
Signed-off-by: Iago Santos Pardo <[email protected]>
6a39ee3
to
d509b29
Compare
Done! |
Thanks @isantospardo for the update, almost LGTM but this pr should be considered as a breaking change, so I'd like to defer this pr to our next major version upgrade (I hope we could make it happened in October). |
default = null | ||
description = <<-EOT | ||
optional(object({ | ||
http_proxy = (Optional) The proxy address to be used when communicating over HTTP. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Changing this forces a new resource to be created." is not true anymore.
References:
Azure/AKS#3524
MicrosoftDocs/azure-docs@0bb10c7
This will probably change soon upstream in the provider. Hold before merging.
I'm closing this pr since I've opened a new one #492 , I've continued @isantospardo's work there. Thanks everyone. |
Describe your changes
Adds a HTTP(S) proxy configuration within this module like described in the upstream Terraform Kubernetes Cluster resource.
This feature is currently not implemented yet and it would let us configure a HTTP(s) proxy for our AKS nodes with a customer CA as well.
You can have a look on a fork which enabled it, please see here.
We are working on a PR already and it will be linked to this issue asap.
Thanks for your understanding and time.
Issue number
#434
Checklist before requesting a review
CHANGELOG.md
fileFixes: #434