Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node_os_channel_upgrade #474

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Add support for node_os_channel_upgrade #474

merged 4 commits into from
Nov 14, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

#419

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@zioproto
Copy link
Collaborator

Should we add a precondition to implement the following ?

Screenshot 2023-11-13 at 08 44 40

@lonegunmanb
Copy link
Member Author

Should we add a precondition to implement the following ?

Screenshot 2023-11-13 at 08 44 40

Good idea! Will do!

jiaweitao001
jiaweitao001 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🚢

@jiaweitao001 jiaweitao001 merged commit 2d48f28 into Azure:main Nov 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Azure Module Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonegunmanb @zioproto @jiaweitao001