Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade notice document #513

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Add upgrade notice document #513

merged 4 commits into from
Mar 5, 2024

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb
Copy link
Member Author

Hi @zioproto I've added an upgrade notice document for incoming v8, would you please give it a review? Thanks!

zioproto
zioproto reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@zioproto zioproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Please check if the section about log analytics needs to be changed. Thanks

NoticeOnUpgradeTov8.0.md Show resolved Hide resolved
NoticeOnUpgradeTov8.0.md Show resolved Hide resolved
NoticeOnUpgradeTov8.0.md Show resolved Hide resolved
NoticeOnUpgradeTov8.0.md Outdated

## Redesign variable for new created `azurerm_log_analytics_workspace`

1. The `cluster_log_analytics_workspace_name` variable has been replaced with a new `new_log_analytics_workspace` variable. This new variable is an object that allows for more granular configuration of the Log Analytics Workspace.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still under development ? Correct ? #515

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct, if we decide to not merge #515 then I'll remove this section.

@lonegunmanb
Copy link
Member Author

Thanks @zioproto for the code review, I've fixed all comments you've left but only one left, I'll decide how should we process this log analysis section once we're on the same page on #515 .

@lonegunmanb lonegunmanb merged commit 57c5c49 into main Mar 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zioproto zioproto Awaiting requested review from zioproto

Assignees
No one assigned
Labels
None yet
Projects
Azure Module Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @zioproto