Add support for node_network_profile for default node pool and extra node pools.

[lonegunmanb]

Describe your changes

node_public_ip_tags looks like a preview feature, but I found that this feature has already been added in extra node pool resource block, so I just add it into default node pool too.

Issue number

#524

Checklist before requesting a review

• The pr title can be used to describe what this pr did in CHANGELOG.md file
• I have executed pre-commit on my machine
• I have passed pr-check on my machine

Thanks for your cooperation!

[lonegunmanb]

Hi @zioproto would you please give this pr a review? Thanks!

[zioproto]

@lonegunmanb I am looking at the feature docs:

https://learn.microsoft.com/en-us/azure/aks/use-node-public-ips#use-public-ip-tags-on-node-public-ips-preview

I think we should hold any change until GA.

[zioproto]

I understand we want to align with was implemented already for the extra node pools to the default node pool.

I propose to add a partial block like we already have also for the default node pool:

dynamic "node_network_profile" {
        for_each = var.agents_pool_node_network_profile == null ? [] : ["node_network_profile"]

        content {
          node_public_ip_tags            = var.agents_pool_node_network_profile.node_public_ip_tags
        }
      }

And to avoid adding more preview features.

my 2 cents