Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed inaccurate variable descriptions for azure cni in overlay mode #566

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Xelef2000
Copy link
Contributor

Describe your changes

The current description for the variable net_profile_pod_cidr is inaccurate since it states that this field can only be set when network_plugin is set to kubenet, but it can (and probably will) be used with the azure cni in overlay mode.

The variable description for network_plugin_mode states, that the only possible value is 'Overlay', which works, but the API will change it to lowercase 'overlay', terraform will attempt to change this to uppercase 'Overlay' during every subsequent apply, according to my testing.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@Xelef2000
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Adfinis"

@zioproto zioproto merged commit bbab24d into Azure:main Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants