Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][arm-common-types] - closing gaps & validation with compare tool #1881

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlitzelMendez
Copy link
Member

common-types still have some differences, we want to remove as much differences as possible so we can call common-types "ready"

I still have some questions that I need to follow up:

  1. visibility versioning - The visibility change across versions, do we have a way to handle this?
  2. parameters section - In some places the parameters section is missing, what role the parameters section plays on the swagger?
  3. @@OpenAPI.extension versioning - There are some extensions that change across versions like x-ms-null
  4. x-ms-arm-id-details - Which is the role? in some places on the original swagger it doesn't exist, but we added it

@AlitzelMendez AlitzelMendez changed the title Common-types - closing gaps & validation with compare tool [arm-common-types] - closing gaps & validation with compare tool Nov 18, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 18, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

common-types consistency with original swagger

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez changed the title [arm-common-types] - closing gaps & validation with compare tool [WIP][arm-common-types] - closing gaps & validation with compare tool Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants