Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8 #99

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update to .NET 8 #99

wants to merge 10 commits into from

Conversation

Sefriol
Copy link

@Sefriol Sefriol commented May 20, 2024

  • Update other dependancies
  • Convert Postman Collection into Playwright API tests
  • Squash commits
  • Remove Newtonsoft?

@Sefriol Sefriol changed the title Update to DotNet 8 Update to .NET 8 May 20, 2024
@Sefriol Sefriol force-pushed the master branch 8 times, most recently from b2df41f to 597d804 Compare May 24, 2024 15:58
@Sefriol Sefriol marked this pull request as ready for review May 24, 2024 16:15
@Sefriol
Copy link
Author

Sefriol commented May 24, 2024

Removal on Newtonsoft might be possible, but requires so much rewrite that it needs its own PR.

While Postman collection was okey for testing, it was rather slow to run and requires a license for those who are most likely candidates to use software like this. I created a Playwright tests that mimic the test cases of the postman collection and improve them a little bit.

I also removed a bunch of files which were not used, but some might be in some other context (like profile pictures and photos?). I am not sure if DataContract classes were auto-generated using some tool, but feel free to give guidance on how to make this PR work.

@boscoMW @marcusca10 Are you currently overseering this repo?

@ibe-SAG
Copy link

ibe-SAG commented Jun 16, 2024

you have a bug in
public static class RequestExtensions
public static Uri GetBaseResourceIdentifier(this HttpContext context)

line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri;
throw exception, because

context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users

you can not build an Uri from incomplete string

@Sefriol
Copy link
Author

Sefriol commented Jun 18, 2024

you have a bug in public static class RequestExtensions public static Uri GetBaseResourceIdentifier(this HttpContext context)

line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; throw exception, because

context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users

you can not build an Uri from incomplete string

Good catch. Fixed.

@garrettlondon1
Copy link

Whats the status of this PR?

@SvatKalashmat
Copy link

also interesting

@Sefriol
Copy link
Author

Sefriol commented Oct 31, 2024

Repository probably needs a complete rewrite. It has a lot of files which are almost impossible to figure out what they are for.

And it seems like there is no current maintainers for this repository, so this PR will most likely go nowhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants