-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 8 #99
base: master
Are you sure you want to change the base?
Update to .NET 8 #99
Conversation
Sefriol
commented
May 20, 2024
•
edited
Loading
edited
- Update other dependancies
- Convert Postman Collection into Playwright API tests
- Squash commits
- Remove Newtonsoft?
b2df41f
to
597d804
Compare
Removal on Newtonsoft might be possible, but requires so much rewrite that it needs its own PR. While Postman collection was okey for testing, it was rather slow to run and requires a license for those who are most likely candidates to use software like this. I created a Playwright tests that mimic the test cases of the postman collection and improve them a little bit. I also removed a bunch of files which were not used, but some might be in some other context (like profile pictures and photos?). I am not sure if DataContract classes were auto-generated using some tool, but feel free to give guidance on how to make this PR work. @boscoMW @marcusca10 Are you currently overseering this repo? |
you have a bug in line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users you can not build an Uri from incomplete string |
- Fixes AzureAD#98
Good catch. Fixed. |
Whats the status of this PR? |
also interesting |
Repository probably needs a complete rewrite. It has a lot of files which are almost impossible to figure out what they are for. And it seems like there is no current maintainers for this repository, so this PR will most likely go nowhere. |