-
Notifications
You must be signed in to change notification settings - Fork 432
Allow usage of relative URIs in AuthnContextClassRef #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glatzert
wants to merge
8
commits into
AzureAD:dev
Choose a base branch
from
jguzdv:ottenhus/allow-relative-authnContextUri
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
779ae2c
Create AppContext Switch to allow relative Uris in AuthnContextClassRef
b557010
Evaluate AppContextSwitch
362d642
Add a test class to validate AppContextSwitch functionality
1042a61
Add a hint about the switch in the remarks
66bf35e
Put tests into a non paralell collection
df1d4e1
Typo
3395d97
Update src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2Authenticat…
glatzert d494769
Update src/Microsoft.IdentityModel.Tokens/AppContextSwitches.cs
glatzert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...crosoft.IdentityModel.Tokens.Saml.Tests/Saml2AuthenticationContextCollectionDefinition.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Xunit; | ||
|
|
||
| namespace Microsoft.IdentityModel.Tokens.Saml.Tests | ||
| { | ||
| [CollectionDefinition("Saml2AuthenticationContextTests", DisableParallelization = true)] | ||
| public class Saml2AuthenticationContextCollectionDefinition | ||
| { | ||
| // This class is used to define a collection for the Saml2AuthenticationContext tests. | ||
| // It allows the tests to run sequentially and share setup/teardown logic if needed. | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...icrosoft.IdentityModel.Tokens.Saml.Tests/Saml2AuthenticationContextWithAppContextTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System; | ||
| using Xunit; | ||
| using Microsoft.IdentityModel.Tokens.Saml2; | ||
|
|
||
| namespace Microsoft.IdentityModel.Tokens.Saml.Tests | ||
| { | ||
| [Collection("Saml2AuthenticationContextTests")] | ||
| public class Saml2AuthenticationContextWithAppContextTests | ||
| { | ||
| [Fact] | ||
| public void Saml2AuthenticationContext_RelativeClassReference_AllowRelativeUris_NoException() | ||
| { | ||
| try | ||
| { | ||
| var classRef = new Uri("resource", UriKind.Relative); | ||
| AppContext.SetSwitch(AppContextSwitches.AllowRelativeUrisInSaml2AuthnContextSwitch, true); | ||
| var authContext = new Saml2AuthenticationContext | ||
| { | ||
| ClassReference = classRef | ||
| }; | ||
| Assert.Equal(classRef, authContext.ClassReference); | ||
| } | ||
| finally | ||
| { | ||
| AppContextSwitches.ResetAllSwitches(); | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.