Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Use hub app's FRT to get nested app's AT #2379

Closed
wants to merge 4 commits into from
Closed

[Bug fix] Use hub app's FRT to get nested app's AT #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a85eb8d
renew AT using FRT logic for nested app
somalaya Apr 12, 2024
f7cef53
changeLog updated
somalaya Apr 12, 2024
17bf7c4
removed newline
somalaya Apr 12, 2024
033c278
Moved entire logic to BrokerLocalController
somalaya Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ V.Next
- [PATCH] Return status code in errorResponse when server response is not in expected Json format. (#2321)
- [PATCH] Reduce the amount of setAccountVisibility() call. (#2355)
- [MINOR] Added telemetry for cross cloud and MSA passthrough requests (#2367)
- [MINOR] [Bug fix] Use hub app's FRT to get nested app's AT (#2379)


V.17.2.0
---------
Expand Down
4 changes: 3 additions & 1 deletion common4j/src/main/com/microsoft/identity/common/java/controllers/BaseController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,15 @@
import com.microsoft.identity.common.java.exception.ClientException;
import com.microsoft.identity.common.java.exception.ErrorStrings;
import com.microsoft.identity.common.java.exception.ServiceException;
import com.microsoft.identity.common.java.exception.UiRequiredException;
import com.microsoft.identity.common.java.foci.FociQueryUtilities;
import com.microsoft.identity.common.java.logging.DiagnosticContext;
import com.microsoft.identity.common.java.logging.Logger;
import com.microsoft.identity.common.java.providers.microsoft.MicrosoftAuthorizationRequest;
import com.microsoft.identity.common.java.providers.microsoft.MicrosoftTokenRequest;
import com.microsoft.identity.common.java.providers.microsoft.microsoftsts.MicrosoftStsAuthorizationRequest;
import com.microsoft.identity.common.java.providers.microsoft.microsoftsts.MicrosoftStsOAuth2Strategy;
import com.microsoft.identity.common.java.providers.microsoft.microsoftsts.MicrosoftStsTokenRequest;
import com.microsoft.identity.common.java.providers.microsoft.microsoftsts.MicrosoftStsTokenResponse;
import com.microsoft.identity.common.java.providers.oauth2.AuthorizationRequest;
import com.microsoft.identity.common.java.providers.oauth2.AuthorizationResponse;
Expand Down Expand Up @@ -670,7 +672,7 @@ public TokenResult renewAccessToken(@NonNull final SilentTokenCommandParameters
return tokenResult;
}

private List<ICacheRecord> getAcquireTokenResultRecords(@NonNull final MicrosoftStsTokenResponse microsoftStsTokenResponse,
protected List<ICacheRecord> getAcquireTokenResultRecords(@NonNull final MicrosoftStsTokenResponse microsoftStsTokenResponse,
@NonNull final MicrosoftStsOAuth2Strategy oAuth2Strategy,
@NonNull final MicrosoftStsAuthorizationRequest authorizationRequest) {
final MicrosoftStsAccountCredentialAdapter credentialAdapter = new MicrosoftStsAccountCredentialAdapter();
Expand Down
Loading