Nonce redirect changes, Fixes AB#3098972 #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
somalaya
changed the title
|
✅ Work item link check complete. Description contains link AB#3098972 to an Azure Boards work item. |
shahzaibj
reviewed
Dec 6, 2024
common/src/main/java/com/microsoft/identity/common/CommonPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Dec 6, 2024
| activity | ||
| ) | ||
| } | ||
| Logger.warn(methodTag, "mPrtCredentialHolder is not initialized!") |
There was a problem hiding this comment.
Should this be an error case and throw?
shahzaibj
reviewed
Dec 6, 2024
common/src/main/java/com/microsoft/identity/common/IPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Dec 6, 2024
common/src/main/java/com/microsoft/identity/common/IPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Dec 6, 2024
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Show resolved
Hide resolved
shahzaibj
reviewed
Dec 6, 2024
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Show resolved
Hide resolved
shahzaibj
reviewed
Dec 6, 2024
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Dec 6, 2024
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
p3dr0rv
reviewed
Dec 6, 2024
common/src/main/java/com/microsoft/identity/common/IPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/com/microsoft/identity/common/CommonPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Outdated
Show resolved
Hide resolved
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Show resolved
Hide resolved
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Dec 7, 2024
common/src/main/java/com/microsoft/identity/common/IPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Dec 7, 2024
common/src/main/java/com/microsoft/identity/common/IPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Dec 7, 2024
common/src/main/java/com/microsoft/identity/common/IPrtCredentialHolder.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Dec 7, 2024
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
somalaya
force-pushed
the
somalaya/nonceRedirect
branch
from
49b2705 to
c862bd8
Compare
somalaya
force-pushed
the
somalaya/nonceRedirect
branch
from
c862bd8 to
4718f68
Compare
mohitc1
reviewed
Jan 2, 2025
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Show resolved
Hide resolved
mohitc1
reviewed
Jan 2, 2025
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Jan 2, 2025
common/src/main/java/com/microsoft/identity/common/IRefreshTokenCredentialProvider.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Jan 2, 2025
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Show resolved
Hide resolved
mohitc1
reviewed
Jan 2, 2025
common/src/main/java/com/microsoft/identity/common/CommonRefreshTokenCredentialProvider.kt
Outdated
Show resolved
Hide resolved
p3dr0rv
reviewed
Jan 2, 2025
common/src/main/java/com/microsoft/identity/common/CommonRefreshTokenCredentialProvider.kt
Outdated
Show resolved
Hide resolved
p3dr0rv
reviewed
Jan 2, 2025
common/src/main/java/com/microsoft/identity/common/CommonRefreshTokenCredentialProvider.kt
Outdated
Show resolved
Hide resolved
p3dr0rv
reviewed
Jan 2, 2025
.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/NonceRedirectHandler.kt
Show resolved
Hide resolved
somalaya
force-pushed
the
somalaya/nonceRedirect
branch
from
4718f68 to
a281be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What : Server can reject nonce sent in PRT header in requests. In this case, server redirects to a url with sso_nonce provided in the URL. Broker should be able to handle redirect and replay request with updated PRT credential using new nonce.
Fixes AB#3098972
Related broker PR : https://github.com/AzureAD/ad-accounts-for-android/pull/3013/files