Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement type-level string append function #726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krame505
Copy link
Contributor

@krame505 krame505 commented Aug 1, 2024

This adds a TApp type pseudo-constructor like TAdd and friends, for appending type-level strings.

@quark17
Copy link
Collaborator

quark17 commented Oct 17, 2024

Looks good! I'm a tad concerned that TApp can be misread as type application (like BSC's TAp), but I'm not sure that I have a better suggestion.

@mieszko
Copy link
Collaborator

mieszko commented Oct 17, 2024

Looks good! I'm a tad concerned that TApp can be misread as type application (like BSC's TAp), but I'm not sure that I have a better suggestion.

Yeah TApp looks to me like application of some kind. Why not just TAppend? Unambiguous, and not too long.

@krame505
Copy link
Contributor Author

I went with TApp mostly for consistency, the other type-level functions are all abbreviated to 3 letters: TAdd, TSub, TMul, TDiv, TLog, TExp, TMax, TMin.

TAppend is a little more verbose. No strong objection, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants