Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment challenge score when a product is ordered & paid but only for whitelisted product #248

Closed
Tirodem opened this issue Jul 4, 2023 · 1 comment
Closed

Increment challenge score when a product is ordered & paid but only for whitelisted product #248

Tirodem opened this issue Jul 4, 2023 · 1 comment
Assignees
@ithiame
Labels
Donator:NPR quick backlog

Comments

@Tirodem
Copy link
Contributor

Tirodem commented Jul 4, 2023

Following #236 , edit the incrementation post-order script ( #110 ) to trigger the challenge incrementation only on whitelisted products amount.
@Tirodem Tirodem mentioned this issue Jul 5, 2023
Open
@ithiame ithiame self-assigned this Jul 7, 2023
@ithiame ithiame mentioned this issue Jul 12, 2023
Merged
@Tirodem
Copy link
Contributor Author

Tirodem commented Jul 13, 2023

Tested ok ✔️
Challenges created before commit take every product in account, even non-whitelisted ones, but it might be related to datas & non-backward compatibility.
Still it's ok for newly created challenges.
And as we're not released yet, we don't mind for old challenges to be impacted so tests OK 🟢

@Tirodem Tirodem closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ithiame ithiame

Labels
Donator:NPR quick backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tirodem @ithiame