Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💵 Add some new currencies #1613 #1618

Merged
merged 1 commit into from
Dec 6, 2024
Merged

💵 Add some new currencies #1613 #1618

merged 1 commit into from
Dec 6, 2024

Conversation

ithiame
Copy link
Contributor

@ithiame ithiame commented Dec 3, 2024

No description provided.

@ithiame ithiame linked an issue Dec 3, 2024 that may be closed by this pull request
@Tirodem
Copy link
Contributor

Tirodem commented Dec 5, 2024

I have some huge doubts about results : ❌

google vs dev-bootik2

image
image

image
image

image
image

image
image

image
image

image
image

image
image

For previous currencies, we're more or less OK (marging related to our exchange rate API) :
image
image

image
image

@coyotte508
Copy link
Collaborator

coyotte508 commented Dec 5, 2024

ah yes @ithiame need to make sure this is valid for the new currencies:


			const resp = await fetch('https://api.coinbase.com/v2/exchange-rates?currency=BTC', {
				...{ autoSelectFamily: true }
			} as unknown as RequestInit);

from currency-lock

@ithiame
Copy link
Contributor Author

ithiame commented Dec 5, 2024

I have good results on my test

Config currencies
image

pricetag
image

image

image

image

image

@coyotte508
Copy link
Collaborator

coyotte508 commented Dec 5, 2024

you can both check exchangeRate in db.runtimeConfig - see if it's updated

@ithiame
Copy link
Contributor Author

ithiame commented Dec 5, 2024

image

@coyotte508
Copy link
Collaborator

Seems good!

Maybe @Tirodem there are multiple processed on the same DB and there was a lock in place, so the currencies didn't update?

(otherwise, deploy again & wait a few minutes. Or run locally)

@Tirodem
Copy link
Contributor

Tirodem commented Dec 6, 2024

I see the records on runtimeConfig, I gonna deploy it again.
Are the datas from src/lib/stores/exchangeRate.ts used at the beginning before we request the exchange API for fresh rates and stock them in runtimeConfig ?
What's the frequency of this call ?

@Tirodem
Copy link
Contributor

Tirodem commented Dec 6, 2024

Amounts are good now.

@Tirodem Tirodem merged commit 690ce16 into main Dec 6, 2024
4 checks passed
@Tirodem Tirodem deleted the add-some-new-currencies branch December 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💵 Add some new currencies
3 participants