Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix discount on receipt #1646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix discount on receipt #1646

wants to merge 1 commit into from

Conversation

ithiame
Copy link
Contributor

@ithiame ithiame commented Dec 12, 2024 •
edited
Loading

@ithiame ithiame requested a review from coyotte508 December 12, 2024 14:49
coyotte508
coyotte508 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@coyotte508 coyotte508 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix for the exact case, still worth it to investigate further for orders with discounts that will have a wrong discount amount.

Still not sure why it happened, it's stranger that the order amount is so different from the price stored for the products. Did the products price update during the order, or from when it was in the cart?

Even if that was the case, it should be refetched/stored correctly in the order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithiame @coyotte508