Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

šŸ› Nostr-bot triggers its welcome message when tagued on non-MP publiā€¦ #1648

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ithiame
Copy link
Contributor

@ithiame ithiame commented Dec 17, 2024

ā€¦cation #1553

@coyotte508
Copy link
Collaborator

I don't understand, this is a frontend change, it doesn't change the behavior of the nostrbot.

(Not sure I understood the issue)

What do we want to do exactly?

@ithiame
Copy link
Contributor Author

ithiame commented Dec 18, 2024

I understand that nostr-bot send welcom message when we tag it in a public discussion, so we don't want this message to be sent anymore (disabling welcom message do the job), and to list only private message.

@coyotte508
Copy link
Collaborator

I understand that nostr-bot send welcome message when we tag it in a public discussion, so we don't want this message to be sent anymore

This PR only changes the frontend, what's displayed in the admin, it doesn't change the behavior of the bot

@ithiame
Copy link
Contributor Author

ithiame commented Dec 18, 2024

This PR only changes the frontend, what's displayed in the admin, it doesn't change the behavior of the bot

You'r right,
Thought disabling notsr-bot intro message will fix the behavior of the bot
Going to fix it

@Tirodem
Copy link
Contributor

Tirodem commented Dec 18, 2024

Thanks for catching the mistake.
Indeed it's not front only and welcome message should be enabled but should process only for MP, not for public @tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

šŸ› Nostr-bot triggers its welcome message when tagued on non-MP publication
3 participants