🦋 Disable pay button as long as the sum up / stripe iframe is not loa… #1665
Conversation
…e-pay-button-sumup-stripe
| setTimeout(() => { | ||
| stripeLoading = false; | ||
| }, 3000); |
There was a problem hiding this comment.
Ideally you can listen to the DOM instead of hardcoding a delay. There is the load event for the document, and for the iframe too if you can find it.
It's what we do to download invoices or bulk invoices, listen to the dom event. For example here: https://github.com/B2Bitcoin/beBOP/pull/1660/files#diff-633ad8803814b1c6ca182165aabc08d46569cba063f15d1fc09e816072366bb0R184-R193
Searching on google I also get some answers: https://stackoverflow.com/questions/52954937/when-are-stripe-elements-ready-in-the-dom https://docs.stripe.com/js/element/events it seems there's a builtin event for that
Please take the time to look for good solutions
There was a problem hiding this comment.
The "blame" is on me here.
I proposed to make a 2 step implementation because this issue costs us (PVH Editions) money with issues on card payment.
I don't mind having a 3-seconds wait asap and a smart solution after.
There was a problem hiding this comment.
ok for the quickfix then I guess cc @Tirodem but please make a follow-up PR to clean that up :)
|
Yes cc @AmadouAgiltoo (but I'd be more into keeping #1631 open as the 2 version were listed on it, we can do 2 checkbox to say first part is done) |
|
OK @Tirodem I'll indicate on the 331 that the quick fix by adding some seconds before display the buttom is done. |
…ded #1631