Skip to content

Harden refund status error log #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jynbil1 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Harden refund status error log #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion common/models/Refund.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@ public static function updateRefundStatus($refundReference, $responseContent) {
$refundRecord->refund_status = $responseContent['RefundStatus'];

if(!$refundRecord->save()) {
Yii::error("Error when updating refund status" . json_encode($refundRecord->errors));
Yii::error([
'message' => 'Error when updating refund status',
'refund_id' => $refundRecord->refund_id,
'refund_reference' => $refundRecord->refund_reference,
'refund_status' => $refundRecord->refund_status,
'errors' => $refundRecord->getErrors()
], __METHOD__);
}

return true;
Expand Down
16 changes: 16 additions & 0 deletions tests/check-refund-status-error-log.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env bash
set -euo pipefail

target="common/models/Refund.php"

grep -q "Error when updating refund status" "$target"
grep -q "refund_reference" "$target"
grep -q "refund_status" "$target"
grep -q "getErrors()" "$target"

if grep -q 'json_encode($refundRecord->errors)' "$target"; then
echo "refund status update still logs raw validation errors as JSON text" >&2
exit 1
fi

echo "Refund status error log guard passed."