Fix candidate ID card generation response handling - #106
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for studenthub-staff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
TypeError: undefined is not an object (evaluating 'r.operation')occurring during candidate ID card generation (SH-STAFF-APP-4).Changes Made:
src/app/providers/logged-in/candidate.id.card.service.ts, thegenerate()method was updated.this._authhttp.generateCards()was replaced withthis._authhttp.post(url, { candidates }).Reasoning:
generateCards()method was intended for downloading a zip file and, due to its implementation, implicitly returnedundefinedfrom itsmapoperator.candidate-search.page.ts) expected a JSON response containing fields likeoperationandcir_uuid.TypeErrorwhen the caller attempted to access properties on theundefinedresponse.this._authhttp.post(), the service now correctly returns the API's JSON response, aligning with the caller's expectations and resolving the error. Any file download functionality should now be handled by the caller based on the content of the JSON response.Fixes SH-STAFF-APP-4
Fixes TECH-2011