[Feature] 분실물 기능 #524
Merged
[Feature] 분실물 기능 #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't access ArticleBoardType from lostandfound module, So copy it for now
When we navigate to another tab, onDestroy always called
yunjaena
requested changes
Jan 18, 2025
| val viewModelStoreOwner = requireNotNull( | ||
| LocalViewModelStoreOwner.current as? HasDefaultViewModelProviderFactory | ||
| ) | ||
| val viewModel: LostAndFoundDetailViewModel = viewModel( |
There was a problem hiding this comment.
savedStateHandle을 통해서 초기값 처리는 힘들까요?
yunjaena
reviewed
Jan 18, 2025
| modifier = Modifier.fillMaxSize(), | ||
| containerColor = KoinTheme.colors.neutral0, | ||
| bottomBar = { | ||
| WriteArticleDoneButton { |
There was a problem hiding this comment.
@kongwoojin bottomBar에 WriteArticleDoneButton 이 세팅되어있는데 해당 컴포넌트 파라미터에 windowInset 대응이 안되어있다는걸 말씀드린겁니다.
| } | ||
| }, | ||
| // Fix wrong top padding value | ||
| contentWindowInsets = WindowInsets(0, 0, 0, 0) |
There was a problem hiding this comment.
windowInsetPadding에 대해서 알아보시면 좋을것 같습니다.
@kongwoojin bottomBar에 WriteArticleDoneButton 이 세팅되어있는데 해당 컴포넌트 파라미터에 windowInset 대응이 안되어있다는걸 말씀드린겁니다.
해당 부분 알아보시면 contentWindowInsets 에 대해서 이해 되실것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
개발 내용
사진
추가적인 내용