Dark theme에서 Status bar 색상 수정 #531
Open
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjaena
requested changes
Jan 27, 2025
기존 코드 revert하고 EdgeToEdgeExtensions를 새로 만들었습니다! |
yunjaena
requested changes
Jan 28, 2025
| /** | ||
| * Enables the edge-to-edge display for this [ComponentActivity] with blue status bar. | ||
| */ | ||
| fun ComponentActivity.enableEdgeToEdgeWithBlueStatusBar() = enableEdgeToEdge( |
There was a problem hiding this comment.
statusbar 색이 api 29 부터 투명색으로 들어가기 때문에 네이밍을 한번 고려해보면 좋을것 같습니다.
그리고 그런케이스 인경우 statusbar 만큼 패딩을 주고 해당 패딩에 background color을 넣는거는 어떨까요?
There was a problem hiding this comment.
어.. 그러니깐 contentWindowInsets를 0으로 설정하고, 패딩값을 상단에 주는걸 말씀하시는거죠?
There was a problem hiding this comment.
일단 enableEdgeToEdgeWithBlueStatusBar()는 enableEdgeToEdgeWithDarkStatusBar()로 수정하고 배경을 Transparent 로 변경했습니다!
말씀하신 상단에 패딩을 주는 부분의 경우, 시도해봤는데 라이트모드/다크모드 변경 시 statusbar의 아이콘 색이 변경되지 않는것 같아서 다른 방법이 있을지 찾아보겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
Design system의 KoinTheme에 isLightStatusBar라는 변수를 추가했습니다. 해당 변수 값에 따라 status bar의 텍스트 색상이 변경됩니다.위의 변경사항에 따라, isLightStatusBar 선언이 필요한 Composable(시간표)에 값을 선언해줬습니다.사진
고민 사항
isLightStatusBar의 기본값을 기존 WindowExtensions과 동일하게 false로 선언했는데, 값 선언을 강제하도록 기본값을 제거하는게 좋을지 고민입니다.