[Feature] 메뉴 관리 페이지 생성 #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongwoojin
reviewed
Feb 12, 2025
| Text( | ||
| modifier = Modifier.padding(horizontal = 20.dp), | ||
| text = state.storeInfo?.name ?: stringResource(R.string.shop_name), | ||
| style = TextStyle(color = Color.Black, fontSize = 20.sp), |
There was a problem hiding this comment.
fontSize가 두번 선언된거 같아요!
| @@ -336,7 +334,7 @@ fun ModifyMenuScreenImpl( | |||
| if(registerMenuState.menuOptionPrice.isEmpty()){ | |||
| Box( | |||
| modifier = modifier | |||
| .border(width = 1.dp, color = ColorMinor) | |||
| .border(width = 1.dp, color = ColorMinor, shape = RoundedCornerShape(8.dp)) | |||
There was a problem hiding this comment.
shape도 디자인 시스템에 선언된 값을 사용하면 좋을 것 같습니다!
| text = item.categoryName, | ||
| style = KoinTheme.typography.medium12, | ||
| color = if(item.isChecked) Color.White else Gray3, | ||
| fontWeight = FontWeight(500), |
There was a problem hiding this comment.
fontWeight를 추가로 선언하신 이유가 있을까요?
There was a problem hiding this comment.
과거 코딩의 산재네요... 확인하고 영향 없으면 삭제할게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐾 개요
🐳 상세 작업
📷 결과 화면