-
Notifications
You must be signed in to change notification settings - Fork 18
Add toil-lib dependency (resolves BD2KGenomics/toil#922) #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,6 +73,7 @@ def check_provided(distribution, min_version, max_version=None, optional=False): | |
| author_email='[email protected]', | ||
| url="https://github.com/BD2KGenomics/toil-scripts", | ||
| install_requires=[ | ||
| 'toil-lib==1.0.2', | ||
| 'tqdm==3.8.0', # FIXME: Remove once ADAM stops using it (superfluous import) | ||
| 'pyyaml==3.11'], | ||
| tests_require=[ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,11 +113,10 @@ | |
|
|
||
| # import from python system libraries | ||
| import argparse | ||
| import copy | ||
| import textwrap | ||
| import copy | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lex sort imports; this one shouldn't have moved. |
||
| from multiprocessing import cpu_count | ||
|
|
||
| import yaml | ||
| # import toil features | ||
| from toil.job import Job | ||
| # these don't seem necessary! but, must be imported here due to a serialization issue | ||
|
|
@@ -130,7 +129,7 @@ | |
| from toil_scripts.gatk_processing.gatk_preprocessing import * #download_gatk_files | ||
| from toil_scripts.rnaseq_cgl.rnaseq_cgl_pipeline import generate_file | ||
|
|
||
| from toil_scripts.lib.programs import mock_mode | ||
| from toil_lib.programs import mock_mode | ||
|
||
|
|
||
| def sample_loop(job, uuid_list, inputs): | ||
| """ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,11 +39,11 @@ | |
| from toil.job import Job | ||
| from toil.lib.spark import spawn_spark_cluster | ||
|
|
||
| from toil_scripts.lib import require | ||
| from toil_scripts.lib.files import copy_files, move_files | ||
| from toil_scripts.lib.programs import docker_call, mock_mode | ||
| from toil_lib import require | ||
| from toil_lib.files import copy_files, move_files | ||
| from toil_lib.programs import docker_call, mock_mode | ||
| from toil_scripts.rnaseq_cgl.rnaseq_cgl_pipeline import generate_file | ||
| from toil_scripts.tools.spark_tools import call_adam, call_conductor, MasterAddress, HDFS_MASTER_PORT, SPARK_MASTER_PORT | ||
| from toil_lib.tools.spark_tools import call_adam, call_conductor, MasterAddress, HDFS_MASTER_PORT, SPARK_MASTER_PORT | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,10 +42,11 @@ | |
|
|
||
| import yaml | ||
| from toil.job import Job | ||
| from toil_lib import require | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1 line of whitespace between
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ran optimize imports before realizing it messed up the
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PyCharm's |
||
| from toil_lib.programs import docker_call | ||
| from toil_lib.urls import s3am_upload | ||
|
|
||
| from toil_scripts import download_from_s3_url | ||
| from toil_scripts.lib import require | ||
| from toil_scripts.lib.programs import docker_call | ||
| from toil_scripts.lib.urls import s3am_upload | ||
| from toil_scripts.rnaseq_cgl.rnaseq_cgl_pipeline import generate_file | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,9 +34,9 @@ | |
| import yaml | ||
| from toil.job import Job | ||
| from toil_scripts import download_from_s3_url | ||
| from toil_scripts.lib import require | ||
| from toil_scripts.lib.programs import docker_call | ||
| from toil_scripts.lib.urls import s3am_upload | ||
| from toil_lib import require | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| from toil_lib.programs import docker_call | ||
| from toil_lib.urls import s3am_upload | ||
| from toil_scripts.rnaseq_cgl.rnaseq_cgl_pipeline import generate_file | ||
|
|
||
| _log = logging.getLogger(__name__) | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small aside, but I think we can get rid of the
tqdmrequirement. I don't see it used anywhere in the codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove it in this PR?