Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to reflect udpates in filters.hd5 #772

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

galaxyumi
Copy link
Contributor

@galaxyumi galaxyumi commented Apr 28, 2022

We recently found an issue with the filter curves in the filters.hd5 (issue #755), which only included filter response. Thus we updated filters.hd5 with total throughputs using stsynphot (PR #757). The vega.hd5 file also has been correspondingly updated as of 4/28/2022 (shared the updated file with @karllark). This PR is a pure docs update to reflect our update in filter curves.

@codecov-commenter
Copy link

Codecov Report

Merging #772 (1638f5c) into master (95e6d0a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   43.14%   43.14%           
=======================================
  Files         103      103           
  Lines        9961     9961           
=======================================
  Hits         4298     4298           
  Misses       5663     5663           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e6d0a...1638f5c. Read the comment docs.

Copy link
Member

@karllark karllark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@karllark karllark merged commit 1c3f4cd into BEAST-Fitting:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants