Skip to content

Conversation

@adecler
Copy link
Member

@adecler adecler commented Oct 19, 2025

NOTE: Depends on

BHoM/BHoM#1698

NOTE: Used by

BHoM/BHoM_UI#531

Issues addressed by this PR

See BHoM/BHoM_UI#531 for details on the full context.

This PR handles deserialisation with the need to pre-load all the BHoM assemblies.
The keep concepts are

  • The relations between types and their containing assemblies are stored in BH.Engine.Base.Global.AssemblyNamePerType
  • This is populated at start by using the content of C:\ProgramData\BHoM\Resources\AssemblyContent.tsv
  • When a type is deserialised, the code checks that the assembly for that type has been loaded already and load it if not.
  • It is worth noting that methods are serialised with their full type description (i.e. the type contain the assembly already) So we use that when it is available.

This PR aligns with the changes made in BHoM/BHoM#1698

Testing procedure for the the first phase of merging

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 23, 2025

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

@adecler just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

@adecler
Copy link
Member Author

adecler commented Oct 26, 2025

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

FAO: @adecler @pawelbaran @IsakNaslundBh
@adecler is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is branch-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 53693286484

@adecler
Copy link
Member Author

adecler commented Oct 26, 2025

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 53693286484

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

@adecler I have now provided a passing check on reference 53693286484 as requested.

@adecler
Copy link
Member Author

adecler commented Oct 26, 2025

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

@adecler to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check unit-tests
  • check versioning

@adecler
Copy link
Member Author

adecler commented Oct 26, 2025

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2025

@adecler to confirm, the following actions are now queued:

  • check null-handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants