Skip to content

Conversation

@GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented May 21, 2025

Issues addressed by this PR

Closes #496

Renamed all assembly files using capital letters for both debug and release.

@GCRA101 GCRA101 self-assigned this May 21, 2025
@GCRA101 GCRA101 added the type:compliance Non-conforming to code guidelines label May 21, 2025
@peterjamesnugent
Copy link
Member

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented May 21, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well change the file name for .csproj and the folder name for consistency.

@GCRA101 GCRA101 force-pushed the ETABS_Toolkit-#496-AlignAssemblyNamesDebugAndRelease branch from 3728163 to 2a54294 Compare May 21, 2025 15:32
@GCRA101
Copy link
Contributor Author

GCRA101 commented May 21, 2025

Peter,
thanks for the review.
You can find the comments incorporated in the latest commit: 2a54294

@GCRA101 GCRA101 requested a review from peterjamesnugent May 21, 2025 15:35
@peterjamesnugent
Copy link
Member

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented May 21, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installer runs with no issue, so happy it won't affect any of the build configs etc.

@Chrisshort92 may just be worth running the ETABS_Adapter to verify it works.

@GCRA101
Copy link
Contributor Author

GCRA101 commented May 28, 2025

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 28, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

@GCRA101 GCRA101 force-pushed the ETABS_Toolkit-#496-AlignAssemblyNamesDebugAndRelease branch from 2a54294 to dc05388 Compare October 28, 2025 11:04
@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2025

@peterjamesnugent, @Chrisshort92,
I've rebased this branch on our develop branch to pick up the updates we've made to the source code over these months.
Tested the branch quickly in grasshopper and all works as expected.
I think we're ready to merge ;)

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chrisshort92 can we get someone else to test this please - pretty much every file has been changed so worth just veryfying with the test scripts it works.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Nov 4, 2025

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check installer

There are 85 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michaelhoehn
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@michaelhoehn to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

@michaelhoehn
Copy link
Contributor

@BHoMBot this is a DevOps instruction. Run a force check on: installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@michaelhoehn I'm sorry, but I am not authorised to take that instruction from you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler
Copy link
Member

adecler commented Nov 4, 2025

@BHoMBot this is a DevOps instruction. Run a force check on: installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@adecler I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@adecler I have provided force checks to the checks requested.

@samuelbasimalla samuelbasimalla self-requested a review November 5, 2025 02:01
@samuelbasimalla
Copy link
Contributor

Started testing this using the standard testing scripts. Tested on ETABS Version 22.7.0 using Rhino 7.

The adapter is successfully connected, however it fails when pushing objects giving the following error message. This could be related to missing graphics related DLL's?
image

Also, it is noted test scripts need to be updated with ETABS settings when using ETABS adapter (as per the recent changes made in BHoM 8.3). Currently, made a workaround in the tested script (Structures - Create, Read and Update Elements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align assembly names between debug and release

6 participants