Add Support for Groups #516

GCRA101 · 2025-11-05T13:08:11Z

Issues addressed by this PR

ETABS Toolkit now allows to push/pull and update objects (i.e. bars, nodes, panels, rigid links and openings) handling corresponding assignments to Groups via Tags.

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23513-AddSupportforGroups/[TestScript.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23513-AddSupportforGroups/TestScript.gh?csf=1&web=1&e=NzN4CF)?csf=1&web=1&e=NzN4CF

Changelog

Add Support for Group in Push/Pull/Update of Bars
Add Support for Group in Push/Pull/Update of Nodes
Add Support for Group in Push/Pull/Update of Panels
Add Support for Group in Push/Pull/Update of Links
Add Support for Group in Push/Pull/Update of Openings

Unnecessary since groupname information is going to be stored in tags.

Add feature allowing to assign pushed bars to corresponding groups.

The Method GetGroupAssign() is not supported in any ETABS API earlier than v18.

…TABS v16 and v17

GCRA101 · 2025-11-05T13:10:12Z

@BHoMBot check installer

michaelhoehn · 2025-11-05T17:39:21Z

@BHoMBot check installer

myriamchourfi · 2025-11-06T15:07:52Z

Groups pushed and pulled successfully!

samuelbasimalla · 2025-11-08T15:41:07Z

Tested this for ETABS Version 22.7.0 using Rhino 7 using the test script provided in @GCRA101's original comment.

The script works as intended:

Each object is assigned to different group tags using "Set Property" and pushed to ETABS
Groups of objects are uniquely assigned to different group tags using "Set Property" and pushed to ETABS
Moreover, the information on group tags is pulled from ETABS along with the BHoM objects and updated as needed and re-pushed using "Update Only" push type.

GCRA101 · 2025-11-20T18:16:48Z

@BHoMBot check installer

bhombot-ci · 2025-11-20T18:16:50Z

@GCRA101 to confirm, the following actions are now queued:

check installer

albertbg028

New feature works as intended.

GCRA101 · 2025-12-01T14:33:17Z

@BHoMBot check ready-to-merge

bhombot-ci · 2025-12-01T14:33:20Z

@GCRA101 to confirm, the following actions are now queued:

check ready-to-merge

GCRA101 · 2025-12-01T14:34:21Z

@peterjamesnugent, @Chrisshort92,
fyi, I think this one is ready for merge. Functionality tested by both Myriam and Samuel.
All BHoMBot checks have passed.

peterjamesnugent

A few changes needed to make some methods generic - also how much does this PR conflict with htppotps://github.com//pull/518 ? One supports unique names whilst the other is supporting tags? I would favour using tags over the unique name PR personally.

Etabs_Adapter/CRUD/Create/Bar.cs

…t type

…ect type

peterjamesnugent

@samuelbasimalla do you want to test this again with the methods being a bit more generic now.

In the test can you use the folowing workflow:

User pushes objects with Tags
User pulls all objects e.g. Bar, Panel etc.
User uses the FilterRequest in https://github.com/BHoM/BHoM/blob/c7a25f7799782f9025ead7f532b04a6cd33c7ff0/Data_oM/Requests/FilterRequest.cs#L28 to specify the Tags`
User makes user of https://github.com/BHoM/BHoM_Engine/blob/ee49f81ea511d7ee0c66a3c13d0d73f1a3677bd8/Data_Engine/Compute/FilterData.cs#L37 to filter the data as needed.
@GCRA101

peterjamesnugent · 2025-12-10T23:50:01Z

Etabs_Adapter/CRUD/Create/_Create.cs

+            /* 1. CHECK ASSIGNED GROUPS */

+            /* Get the list of unique groupNames assigned to the BHoM Bar */
+            List<string> groupNames = obj.Tags.Distinct().ToList();


Tags are a Hashset<string> so you don't need to get Distinct() here.

samuelbasimalla · 2025-12-11T06:37:59Z

@samuelbasimalla do you want to test this again with the methods being a bit more generic now.

In the test can you use the folowing workflow:

User pushes objects with Tags

User pulls all objects e.g. Bar, Panel etc.

User uses the FilterRequest in https://github.com/BHoM/BHoM/blob/c7a25f7799782f9025ead7f532b04a6cd33c7ff0/Data_oM/Requests/FilterRequest.cs#L28 to specify the Tags`

User makes user of https://github.com/BHoM/BHoM_Engine/blob/ee49f81ea511d7ee0c66a3c13d0d73f1a3677bd8/Data_Engine/Compute/FilterData.cs#L37 to filter the data as needed.
@GCRA101

Happy to test this as per suggested workflow.
@GCRA101 is the msi installer available in the SharePoint the latest one, after making the changes?

GCRA101 added 17 commits October 29, 2025 22:18

Create ETABSGroup.cs class in ETABS_oM

497757c

Delete ETABSGroup.cs

4dd775a

Unnecessary since groupname information is going to be stored in tags.

Add SetGroup Method to Create/Bar.cs

915b00f

Add feature allowing to assign pushed bars to corresponding groups.

Add Support for Group Feature for Push/Pull of Nodes

c63a3ab

Add Support for Group Feature for Push of Bars

49a09c9

Add Support for Group Feature for Push/Pull of Links

bed45c9

Add Support for Group Feature for Push/Pull of Panels

e7a1d78

Add Support for Group Feature for Push/Pull of Openings

c12c00f

Fix Support of Group feature in Push for Links, Openings and Panels

fc85629

Add UpdateGroup Feature for Bars

16139fb

Add UpdateGroup feature for Nodes

4c16477

Add UpdateGroup feature for Panels

781c2d9

Add UpdateGroup Feature for Links

6118b76

Add UpdateGroup Feature for Openings

ba206b3

Prevent UpdateGroup() method form running with ETABS v16 and v17.

5bbdafe

The Method GetGroupAssign() is not supported in any ETABS API earlier than v18.

Fix syntax error in Update/Bar.cs

d1a0f25

Add missing logic preventing UpdateGroup() method from running with E…

3246f23

…TABS v16 and v17

GCRA101 self-assigned this Nov 5, 2025

GCRA101 added type:feature New capability or enhancement severity:medium Slows progress, but workaround is possible labels Nov 5, 2025

GCRA101 requested review from Chrisshort92, IsakNaslundBh and peterjamesnugent November 5, 2025 13:08

Fix bug panel.Tags.Add() with non perfectly vertical panels

fb0f89e

GCRA101 requested review from albertbg028 and samuelbasimalla December 1, 2025 12:58

albertbg028 previously approved these changes Dec 1, 2025

View reviewed changes

GCRA101 requested a review from marinaBal December 3, 2025 12:17

peterjamesnugent requested changes Dec 5, 2025

View reviewed changes

Etabs_Adapter/CRUD/Create/Bar.cs Outdated Show resolved Hide resolved

Etabs_Adapter/CRUD/Create/Bar.cs Outdated Show resolved Hide resolved

GCRA101 mentioned this pull request Dec 8, 2025

Improve Error Message of SetProperty.cs when input property is Tags BHoM/BHoM_UI#532

Open

Replace type-specific SetGroup methods with one for generic BHoMObjec…

497fa32

…t type

GCRA101 dismissed albertbg028’s stale review via 497fa32 December 8, 2025 19:20

Replace type-specific ResetGroup methods with one for generic BHoMObj…

d7d3988

…ect type

GCRA101 requested a review from peterjamesnugent December 8, 2025 19:44

peterjamesnugent mentioned this pull request Dec 10, 2025

Add Support for Editing Unique Names #518

Closed

peterjamesnugent reviewed Dec 10, 2025

View reviewed changes

Add Support for Groups #516

Are you sure you want to change the base?

Add Support for Groups #516

Uh oh!

Conversation

GCRA101 commented Nov 5, 2025

Issues addressed by this PR

Test files

Changelog

Uh oh!

GCRA101 commented Nov 5, 2025

Uh oh!

michaelhoehn commented Nov 5, 2025

Uh oh!

myriamchourfi commented Nov 6, 2025

Uh oh!

samuelbasimalla commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GCRA101 commented Nov 20, 2025

Uh oh!

bhombot-ci bot commented Nov 20, 2025

Uh oh!

albertbg028 left a comment

Choose a reason for hiding this comment

Uh oh!

GCRA101 commented Dec 1, 2025

Uh oh!

bhombot-ci bot commented Dec 1, 2025

Uh oh!

GCRA101 commented Dec 1, 2025

Uh oh!

peterjamesnugent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peterjamesnugent left a comment

Choose a reason for hiding this comment

Uh oh!

peterjamesnugent Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

samuelbasimalla commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

samuelbasimalla commented Nov 8, 2025 •

edited

Loading