Skip to content

Conversation

Copy link

Copilot AI commented Nov 13, 2025

NOTE: Depends on

Issues addressed by this PR

Closes #563

Implements Update functionality for LoadCombinations in Robot_Adapter. The Update method now:

  • Locates existing combinations using the Number property via direct Get() call (following Loadcases pattern)
  • Updates combination names and replaces case factors
  • Validates RobotId/Number consistency and logs errors on mismatch
  • Provides clear warnings when combinations don't exist in Robot

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Robot_Toolkit/%23563-add-update-load-combination-to-adapter-push?csf=1&web=1&e=VbfBDC

Changelog

Update functionality for LoadCombinations in Robot_Adapter

Additional comments


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix Robot Toolkit update load combination in adapter Implement Update method for LoadCombinations in Robot_Adapter Nov 13, 2025
Copilot AI requested a review from staintono November 13, 2025 11:41
@staintono staintono marked this pull request as ready for review November 13, 2025 11:43
@staintono staintono merged commit 0e0d306 into Robot_Toolkit-#563-add-update-load-combination-to-adapter-push Nov 13, 2025
1 check passed
@staintono staintono deleted the copilot/sub-pr-565 branch November 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants