Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

740 update to new teaser use conditions #741

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

DaJansenGit
Copy link
Member

@DaJansenGit DaJansenGit commented Oct 28, 2024

Before we can merge this, we need to

  • merge Use pyproject.toml for everything and update test resources problem #732 to include the new test resources strategy
  • merge dev into main and create a release. This is needed as the changes here will change the results of the simulations and we want to link a release with the current results in our paper
  • update the templates in the new test resources repository to add the new attributes and add "version" entry in all templates
  • Adjust the main plugin comfort templates that stay in the base repository.
    • cleanup comfort assets (move to test resources)
    • rename version 0.7 to TEASER-0.7
    • add new lighting parameters to comfort use conditions
  • update reference results if we want to have the maintained_illuminance calculation as default (which I suggest due to much more realistic internal loads through lights)

This closes #740

@DaJansenGit DaJansenGit linked an issue Oct 28, 2024 that may be closed by this pull request
@DaJansenGit DaJansenGit self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to new teaser use conditions
2 participants