MF Register Direction: Descriptive Members #6162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
component: core
ax3l
force-pushed
the
topic-py-dimensions-nice
branch
from
71462b9 to
90612cf
Compare
ax3l
commented
Sep 12, 2025
ax3l
force-pushed
the
topic-py-dimensions-nice
branch
3 times, most recently
from
05a4fd4 to
2a50ef1
Compare
ax3l
changed the title
ax3l
force-pushed
the
topic-py-dimensions-nice
branch
2 times, most recently
from
d356d4c to
a72f177
Compare
ax3l
force-pushed
the
topic-py-dimensions-nice
branch
from
d66a8b1 to
6d31ecf
Compare
|
@EZoni interesting observation: the 1D test fails to build but the Azure Pipelines Let us check why. It is good to error out immediately so one does not see a confusing follow-up error on compile issues. |
ax3l
commented
Sep 12, 2025
Source/Diagnostics/BTDiagnostics.cpp
Outdated
| @@ -582,23 +582,23 @@ BTDiagnostics::InitializeFieldFunctors (int lev) | |||
| m_cell_center_functors.at(lev).size()); | |||
| for (int comp=0; comp<m_cell_center_functors_at_lev_size; comp++){ | |||
| if ( m_cellcenter_varnames[comp] == "Ex" ){ | |||
| m_cell_center_functors[lev][comp] = std::make_unique<CellCenterFunctor>(fields.get(FieldType::Efield_aux, Direction{0}, lev), lev, m_crse_ratio); | |||
| m_cell_center_functors[lev][comp] = std::make_unique<CellCenterFunctor>(fields.get(FieldType::Efield_aux, Direction::x, lev), lev, m_crse_ratio); | |||
There was a problem hiding this comment.
Looks like the RCylinder code (accidentially?) compiles/uses this (very Cartesian-looking?) code section:
FAILED: [code=1] CMakeFiles/lib_rcylinder.dir/Source/Diagnostics/BTDiagnostics.cpp.o
/usr/bin/ccache /usr/bin/c++ -DABLASTR_USE_FFT -DAMREX_SPACEDIM=1 -DAMReX_FFTW_OMP=1 -DWARPX_DIM_RCYLINDER -DWARPX_QED -DWARPX_STATIC_DEFINE -DWARPX_USE_FFT -DWARPX_USE_OPENPMD -DWarpX_FFTW_OMP=1 -Dlib_rsphere_EXPORTS -I/home/vsts/work/1/s/Source -I/home/vsts/work/1/s/build/Source -I/home/vsts/work/1/s/build/_deps/fetchedopenpmd-src/include -I/home/vsts/work/1/s/build/_deps/fetchedopenpmd-build/include -I/home/vsts/work/1/s/build/_deps/fetchedpicsar-src/multi_physics/QED/include -I/home/vsts/work/1/s/build/_deps/fetchedamrex-src/Tools/C_scripts -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/Base -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/Base/Parser -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/Boundary -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/AmrCore -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/LinearSolvers -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/LinearSolvers/MLMG -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/Particle -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-src/Src/FFT -isystem /home/vsts/work/1/s/build/_deps/fetchedamrex-build -isystem /usr/lib/x86_64-linux-gnu/openmpi/include -isystem /usr/lib/x86_64-linux-gnu/openmpi/include/openmpi -g1 -Wall -Wextra -Wpedantic -Wshadow -Woverloaded-virtual -Wunreachable-code -O3 -DNDEBUG -std=c++17 -fPIC -fopenmp -finline-limit=43210 -MD -MT CMakeFiles/lib_rcylinder.dir/Source/Diagnostics/BTDiagnostics.cpp.o -MF CMakeFiles/lib_rcylinder.dir/Source/Diagnostics/BTDiagnostics.cpp.o.d -o CMakeFiles/lib_rcylinder.dir/Source/Diagnostics/BTDiagnostics.cpp.o -c /home/vsts/work/1/s/Source/Diagnostics/BTDiagnostics.cpp
/home/vsts/work/1/s/Source/Diagnostics/BTDiagnostics.cpp: In member function ‘virtual void BTDiagnostics::InitializeFieldFunctors(int)’:
/home/vsts/work/1/s/Source/Diagnostics/BTDiagnostics.cpp:585:130: error: ‘x’ is not a member of ‘ablastr::fields::Direction’
585 | m_cell_center_functors[lev][comp] = std::make_unique<CellCenterFunctor>(fields.get(FieldType::Efield_aux, Direction::x, lev), lev, m_crse_ratio);
| ^
will simply keep the general write style as before and revert this.
@dpgrote is this intentional or maybe lacking an #ifdef?
This reverts commit 6d31ecf.
ax3l
force-pushed
the
topic-py-dimensions-nice
branch
from
b3138f6 to
38f3597
Compare
ax3l
commented
Sep 12, 2025
| return mf_name( | ||
| name | ||
| .append("[") | ||
| .append("[dir=") |
There was a problem hiding this comment.
@roelof-groenewald @RemiLehe @dpgrote just highlighting that this is a breaking change if someone uses the "raw old strings" still in Python instead of the APIs we defined a year ago. I do not think someone does and our wrappers are mostly used anyway, which do the right thing...
There was a problem hiding this comment.
@n01r I think that you may have some scripts that use this. Just flagging the breaking change here.
There was a problem hiding this comment.
Should the use of the internal names be deprecated?
There was a problem hiding this comment.
Yes, ideally. This is mostly to make sure that list() looks understandable.
Do we use internal names still somewhere?
RemiLehe
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify calls t other
MultiFabRegisterby adding descriptive member variables toablastr::fields::Directionas well as string conversion. Fix internal values fordirto make sense in other dimensions than 3D, too.Isolated from #6154
To Do
Direction{0} -> 'r', etc.Direction{0} -> 'x', etc. where explicitly Cartesian code is written