Skip to content

Conversation

@quang-le
Copy link
Member

@quang-le quang-le commented Jul 28, 2025

PRs related to LQAS country block will be merged here

Related JIRA tickets : POLIO-1971, POLIO-1982

Self proofreading checklist

  • Did I use eslint and ruff formatters?
  • Is my code clear enough and well documented?
  • Are my typescript files well typed?
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests?
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

Explain the changes that were made.

The idea is not to list exhaustively all the changes made (GitHub already provides a full diff), but to help the reviewers better understand:

  • which specific file changes go together, e.g: when creating a table in the front-end, there usually is a config file that goes with it
  • the reasoning behind some changes, e.g: deleted files because they are now redundant
  • the behaviour to expect, e.g: tooltip has purple background color because the client likes it so, changed a key in the API response to be consistent with other endpoints

How to test

Explain how to test your PR.

If a specific config is required explain it here: dataset, account, profile, etc.

Print screen / video

Upload here print screens or videos showing the changes.

Notes

Things that the reviewers should know:

  • known bugs that are out of the scope of the PR
  • other trade-offs that were made
  • does the PR depends on a PR in bluesquare-components?
  • should the PR be merged into another PR?

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@quang-le quang-le marked this pull request as draft July 28, 2025 07:14
@quang-le quang-le changed the title Polio 1971 lqas country block POLIO-1971 lqas country block dev branch Jul 28, 2025
quang-le and others added 20 commits July 28, 2025 10:36
- removes uses of all_objects
- remove use of field in test data
- models in iaso and polio not updated yet
- remove filter on domain
quang-le and others added 27 commits August 5, 2025 09:16
- add tests
- split test file
- optimize subactivity DB query
@beygorghor beygorghor changed the base branch from main to develop September 9, 2025 14:16
@quang-le
Copy link
Member Author

closing as dev is on hold

@quang-le quang-le closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants