-
Notifications
You must be signed in to change notification settings - Fork 8
IA-4485 LQAS planning pipelines #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hat/assets/js/apps/Iaso/domains/assignments/components/OpenhexaIntegrationDrawer.tsx
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/ExcludedOrgUnits.tsx
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/ExcludedOrgUnits.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/LQASForm.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/constants.ts
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/hooks/useLaunchTask.ts
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/hooks/usePipelineParameters.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only read the backend code: there are a few things I would change, but nothing major. I guess this could work like that.
We should take some time to investigate a couple of suggestions I made - I'm not sure if they are feasible or not
hat/assets/js/apps/Iaso/domains/assignments/hooks/requests/usePollTask.ts
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/LQASForm.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/LQASForm.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/customForms/LQASForm.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/hooks/useGetPipelineDetails.ts
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/openHexa/hooks/usePipelineParameters.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/plannings/components/PlanningDialog.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/plannings/components/PlanningDialog.tsx
Outdated
Show resolved
Hide resolved
const addToArray = useCallback( | ||
const add = useCallback( | ||
(arrayName: string, value: any = undefined) => { | ||
const currentArray = parameterValues?.[arrayName] || []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important but:
addToArray already do this check const currentArray = [...(array || [])];
You could just have: const updatedArray = addToArray(value, parameterValue?.[arrayName]);
Same for other array functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
First PR to implement LQAS sampling in micro-planning.
Related JIRA tickets : IA-4485
Self proofreading checklist
Doc
Here
Changes
openhexa
is configuredopenhexa
is configuredHow to test
Print screen / video
Screen.Recording.2025-09-30.at.14.38.33.mov
Notes
You'll need to adapt Iaso cutom connection to use a ngrok url and use specific credential to update the task on your machine
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.