Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue in xyrasTransform function #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix issue in xyrasTransform function #2

wants to merge 5 commits into from

Conversation

Rui-Jesus
Copy link
Collaborator

No description provided.

@Rui-Jesus Rui-Jesus requested a review from Enet4 February 3, 2022 10:23
@Enet4 Enet4 changed the title Fixed issue in xyrasTransform function Fix issue in xyrasTransform function Feb 3, 2022
Enet4
Enet4 requested changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better also double check the formatting, there appear to be multiple leading spaces where they are not expected.

io/parser.js Outdated Show resolved Hide resolved
@Rui-Jesus Rui-Jesus requested a review from Enet4 April 11, 2022 16:15
Enet4
Enet4 requested changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned issues are still present. Please look into excess whitespace in this pull request (e.g. more than 3 newlines in a row; lines containing nothing but spaces), and for syntax which is not compatible with ECMAScript 5.

io/parser.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rui-Jesus @Enet4