Params and users #11
Open
Params and users #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if one does not yet exist when a ticket is created, making some parameters optional in service of those goals.
|
Hey, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This API that you've made is great. The code is awesome. I'm not sure if these changes will be useful for you or others, but figured I'd let you take a look. Also, I'm not sure I've followed your style sufficiently, apologies for the hacks.
In general - I was wanting a couple things: first, to be able to add tickets from our CRM, and add a user if needed. So with these mods, we can first check if the user existed in OST, and if they didn't, add them automatically.
Second, the tickets from this API were not using the 'status' field in some views, and the title was displaying differently from manually created tickets. I added some insert queries to add form table data, where it seems those are stored? The result looks more 'complete' in my environment when reviewing tickets.
Finally, we wanted a way to add internal notes when a ticket is created from our CRM. It's a useful way to get agents up to speed, without having that info viewable. So, I added this via some new "optionalParameters" hacking...
Most other things were minor. Apologies for the 'spacing' changes, it seems my VIM does that automatically...
Thanks again for this project and all the best!