Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: when computing disk usage, don't include VM shared directories #3901

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidpanderson
Copy link
Contributor

These directories are inside the VM, so we've already counted them.
Also, traversing them can be very slow if the dir is big (e.g. nanoHUB@home)

These directories are inside the VM, so we've already counted them.
Also, traversing them can be very slow if the dir is big (e.g. nanoHUB@home)
@davidpanderson
Copy link
Contributor Author

The Travis CI build is failing on fetching sqlite.
This can be removed; sqlite isn't used anymore.

@AenBleidd
Copy link
Member

@davidpanderson, I see sqlite3 usage still in browser.cpp
Should these functions be deleted from this class (or maybe even the whole class)?

@AenBleidd
Copy link
Member

@davidpanderson
Copy link
Contributor Author

davidpanderson commented Jul 14, 2020 via email

@davidpanderson
Copy link
Contributor Author

That file (browser.cpp) should be removed.

@AenBleidd
Copy link
Member

@davidpanderson, it's already removed in a different PR

@davidpanderson
Copy link
Contributor Author

Actually, it turns out that shared/ resides in the host FS,
But apparently if the host (i.e. BOINC client) accesses it while the VM is running,
there's a locking mechanism or something that makes it very slow.
So let's not merge this for now.

@AenBleidd
Copy link
Member

I'm changing this PR to draft then. Feel free to change it back when you think it's ready

@AenBleidd AenBleidd marked this pull request as draft July 16, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants