Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set arm-unknown-linux-gnueabihf as alt platform on aarch64 #4081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CallMeFoxie
Copy link
Contributor

Description of the Change
Adds arm-unknown-linux-gnueabihf as alt platform to aarch64*linux-gnu. HF as all armv8+ devices have hard float, plus -gnueabihf is known platform for projects.

Alternate Designs
None

Release Notes
Adds arm-unknown-linux-gnueabihf as alt platform to aarch64*linux-gnu devices.

@CallMeFoxie CallMeFoxie force-pushed the arm64-arm-alt-platform branch from 7859e55 to 48076df Compare November 4, 2020 07:58
@truboxl
Copy link
Contributor

truboxl commented Nov 4, 2020

Users still need to enable 32bit support in their aarch64 Linux environment, so hooray for one less setup step?

@CallMeFoxie
Copy link
Contributor Author

You mean libc etc? If the app isn't compiled statically then yeah (WCG is static and runs fine, U@H requires libraries in the OS). isn't the same being done for amd64/i686 though? (lines 26 - 32)

@truboxl
Copy link
Contributor

truboxl commented Nov 5, 2020

Ok. BOINC docs also point out on amd64 Linux, some 32bit dependencies are needed to be installed manually.
So LGTM. But I am still skeptical on whether ALL the armv8+ chips support for 32bit still hold true in the future...

@SETIguy
Copy link
Contributor

SETIguy commented Nov 5, 2020 via email

@truboxl
Copy link
Contributor

truboxl commented Jan 14, 2021

As explained, there are armv8 aarch64 chips that don't support aarch32, so we need to have a test like SETIguy said and not blindly adding support. This is why I oppose it in #3740 for Android. It may happen in 2022 that true 64bit arm processors will arrive.

Here are some supplemental information:
https://www.arm.com/company/news/2020/10/pushing-the-boundaries-of-performance-and-security-to-unleash-the-power-of-64-bit-computing
https://www.xda-developers.com/future-arm-cpu-drop-support-32-bit-apps/
https://stackoverflow.com/questions/65318052/run-armv8-codes-in-m1-chip#comment115484044_65318052
https://stackoverflow.com/questions/64949775/how-to-find-out-if-an-armv8-processor-supports-the-aarch32-execution-state

@CallMeFoxie
Copy link
Contributor Author

you're right, it should be added. I honestly didn't know about the x86 alt platform code on x86_64, I just went by other platforms code for android :) yeah it should be done by checking for ld-linux at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants